train number API spec #391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawi-coding
requested changes
Nov 19, 2024
| type = "number", | ||
| format = "double", | ||
| description = "Timestamp of the start of train operation in seconds since epoch or timestamp", | ||
| example = "1727188352.001" |
There was a problem hiding this comment.
Double finde ich nicht besonders sinnvoll für Timestamp. Lieber mit ISO oder INT arbeiten.
mghilardelli
commented
Nov 19, 2024
| @RequestMapping("api/v1/train-numbers") | ||
| @Tag(name = "Train numbers", description = "API for train numbers") | ||
| class TrainNumberController { | ||
|
|
mghilardelli
commented
Nov 19, 2024
| ] | ||
| ) | ||
| @PostMapping(consumes = ["application/json"]) | ||
| fun addTrainNumbers(@RequestBody trainNumbers: List<TrainNumberDto>) { |
There was a problem hiding this comment.
insert, update, delete aufgrund keys nummer, ru, betriebstag
mghilardelli
commented
Nov 19, 2024
| description = "Train number alphanumeric", | ||
| example = "123" | ||
| ) | ||
| val number: String, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Grodien @rawi-coding Please review the api spec.
The idea is that an adapter is going to write the train numbers periodically to the api. May also receive updates. start is the datetime of train start as SFERA specifies no operational date
TODOs