chore: refactor structure #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawi-coding
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Sieht sehr gut aus, gefällt mir viel besser 👍
Ich würde noch Folgendes anpassen:
widget_extensions.dartgehört für mich in die App-Component.i18nwürde ich auch eher in der App-Component sehen oder denkst du, das wird ausserhalb des UIs noch verwendet?
Das ist nur ein Hinweis und für den Moment egal aber später wird die Aufteilung bloc / pages vermutlich zu generell, da es Page- und App-spezifische BLoCs geben wird. Die Struktur davon können wir uns aber später überlegen.
das_client/lib/app/pages/journey/train_journey/widgets/train_journey.dart
Show resolved
Hide resolved
rawi-coding
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.