Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-compose): use npm ci for nextjs service #72

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(docker-compose): use npm ci for nextjs service #72

merged 1 commit into from
Oct 23, 2024

Conversation

TheJoin95
Copy link
Member

🔗 Linked issue

Referring to an issue while #49 is in dev on node_modules not refreshing in nextjs docker service.
This PR will provide the fix

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@TheJoin95 TheJoin95 changed the title fix(docer-compose): use npm ci for nextjs service fix(docker-compose): use npm ci for nextjs service Oct 23, 2024
davideimola
davideimola approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@davideimola davideimola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheJoin95 TheJoin95 merged commit c9492ce into main Oct 23, 2024
1 check passed
@TheJoin95 TheJoin95 deleted the fix/docker/node-modules branch October 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideimola davideimola davideimola approved these changes

@404answernotfound 404answernotfound Awaiting requested review from 404answernotfound

@LobeTia LobeTia Awaiting requested review from LobeTia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheJoin95 @davideimola