Fix offline mode

client/schematic_client_test.go

@@ -177,8 +177,33 @@ func TestMultipleEventBatches(t *testing.T) {
 	time.Sleep(20 * time.Millisecond)
 }
 
-func TestCheckFlagOfflineMode(t *testing.T) {
-	client := schematicclient.NewSchematicClient()
+func TestCheckFlagOfflineModeNoAPIKeyOption(t *testing.T) {
+	// Passing mock HTTP client, which we expect to be replaced by a NoopClient internally. This test will fail if any calls are made to the mock client.
+	ctrl := gomock.NewController(t)
+	mockHTTPClient := mocks.NewMockHTTPClient(ctrl)
+	client := schematicclient.NewSchematicClient(option.WithHTTPClient(mockHTTPClient))
+	client.SetFlagDefault("test-flag", true)
+	defer client.Close()
+
+	assert.True(t, client.CheckFlag(context.Background(), &schematicgo.CheckFlagRequestBody{}, "test-flag"))
+}
+
+func TestCheckFlagOfflineModeEmptyAPIKey(t *testing.T) {
+	// Passing mock HTTP client, which we expect to be replaced by a NoopClient internally. This test will fail if any calls are made to the mock client.
+	ctrl := gomock.NewController(t)
+	mockHTTPClient := mocks.NewMockHTTPClient(ctrl)
+	client := schematicclient.NewSchematicClient(option.WithAPIKey(""), option.WithHTTPClient(mockHTTPClient))
+	client.SetFlagDefault("test-flag", true)
+	defer client.Close()
+
+	assert.True(t, client.CheckFlag(context.Background(), &schematicgo.CheckFlagRequestBody{}, "test-flag"))
+}
+
+func TestCheckFlagOfflineModeOption(t *testing.T) {
+	// Passing mock HTTP client, which we expect to be replaced by a NoopClient internally. This test will fail if any calls are made to the mock client.
+	ctrl := gomock.NewController(t)
+	mockHTTPClient := mocks.NewMockHTTPClient(ctrl)
+	client := schematicclient.NewSchematicClient(option.WithOfflineMode(), option.WithHTTPClient(mockHTTPClient))
 	client.SetFlagDefault("test-flag", true)
 	defer client.Close()
 

core/custom_options.go

@@ -4,6 +4,7 @@ import (
 	"time"
 
 	cache "github.com/schematichq/schematic-go/cache"
+	"github.com/schematichq/schematic-go/http"
 )
 
 // Specify default flag values
@@ -86,6 +87,7 @@ type ClientOptOfflineMode struct {
 
 func (c ClientOptOfflineMode) applyRequestOptions(opts *RequestOptions) {
 	opts.OfflineMode = c.isOffline
+	opts.HTTPClient = http.NewNoopClient()
 }
 
 func WithOfflineMode() RequestOption {

http/offline.go

@@ -16,3 +16,7 @@ func (c NoopClient) Do(*gohttp.Request) (*gohttp.Response, error) {
 		Body:       io.NopCloser(strings.NewReader("")),
 	}, nil
 }
+
+func NewNoopClient() NoopClient {
+	return NoopClient{}
+}