Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an external resolver integration test #1425

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

zaro0508
Copy link
Contributor

@zaro0508 zaro0508 commented Jan 23, 2024

An AWS profile was used to run integration tests in circleci. We have moved to github actions and we've also moved to using GH OIDC instead of an AWS profile. A test that validates the use of a profile was passing in circleci but is now failing in GH actions. Since we no longer use a profile we cannot run tests to validate the usage of profiles therefore it has been removed.

An AWS profile was used to run integration tests in circleci.
Now that we've moved to github actions we've also moved to
using GH OIDC instead of an AWS profile.

Since we no longer use a profile we cannot run tests to validate
the use of profiles.
@zaro0508 zaro0508 changed the title Comment out an external resolver integration test Remove an external resolver integration test Jan 23, 2024
Copy link
Contributor

@alex-harvey-z3q alex-harvey-z3q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zaro0508 zaro0508 merged commit dcdf1d1 into Sceptre:master Jan 24, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants