Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GH workflows #1416

Merged
merged 12 commits into from
Jan 26, 2024
Merged

Refactor GH workflows #1416

merged 12 commits into from
Jan 26, 2024

Conversation

zaro0508
Copy link
Contributor

@zaro0508 zaro0508 commented Jan 16, 2024

Refactor Github action from a single workflow to multiple workflows. The purpose is to make the workflows easier to follow and understand. Explanation of workflows..

  • check: runs before a merge (i.e. PRs) or after a push (merge or forced push). Mainly for running quick validation jobs.
  • gate: runs after a merge or a forced push to any branch. Allows admins to trigger long running integration tests as a gate to merging into the main branch.
  • release: runs on a tag to publish Sceptre to registries and repositories

Refactor Github action from a single workflow to multiple workflows.
The purpose is to make the workflows easier to follow and understand.
Copy link
Member

@tarkatronic tarkatronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments and questions!

.github/workflows/integration-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/staging.yaml Outdated Show resolved Hide resolved
@zaro0508
Copy link
Contributor Author

i've made quite a few changes to PR #1420 since your review @tarkatronic. let's get that merged first and i'll redo this PR. With the job dependencies setup in #1420 i'm still not sure it's possible or even worth it to split this setup into multiple workflows.

.github/workflows/push.yaml Outdated Show resolved Hide resolved
@zaro0508
Copy link
Contributor Author

@tarkatronic i've redone this PR with updated files. could you please take another look?

@zaro0508 zaro0508 requested a review from tarkatronic January 24, 2024 18:27
Copy link
Member

@tarkatronic tarkatronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Fun fact for the future, it may be possible to do away with the PYPI_API_TOKEN secret, using PyPI's "Trusted Publishers" setup: https://docs.pypi.org/trusted-publishers/

.github/workflows/check.yaml Show resolved Hide resolved
@zaro0508
Copy link
Contributor Author

Fun fact for the future, it may be possible to do away with the PYPI_API_TOKEN secret, using PyPI's "Trusted Publishers" setup: https://docs.pypi.org/trusted-publishers/

Yeah, i notice that. The problem with that setup is that it needs to be configure every time we create a new repo (think of sceptre plugin) in this org which means that it's another manual bootstrapping step. Tokens on the other hand can be shared at the org level so less manual setup.

@zaro0508 zaro0508 requested a review from tarkatronic January 26, 2024 18:31
@zaro0508 zaro0508 merged commit f6ba551 into Sceptre:master Jan 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants