-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GH workflows #1416
Refactor GH workflows #1416
Conversation
Refactor Github action from a single workflow to multiple workflows. The purpose is to make the workflows easier to follow and understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments and questions!
i've made quite a few changes to PR #1420 since your review @tarkatronic. let's get that merged first and i'll redo this PR. With the job dependencies setup in #1420 i'm still not sure it's possible or even worth it to split this setup into multiple workflows. |
@tarkatronic i've redone this PR with updated files. could you please take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Fun fact for the future, it may be possible to do away with the PYPI_API_TOKEN
secret, using PyPI's "Trusted Publishers" setup: https://docs.pypi.org/trusted-publishers/
Yeah, i notice that. The problem with that setup is that it needs to be configure every time we create a new repo (think of sceptre plugin) in this org which means that it's another manual bootstrapping step. Tokens on the other hand can be shared at the org level so less manual setup. |
Refactor Github action from a single workflow to multiple workflows. The purpose is to make the workflows easier to follow and understand. Explanation of workflows..