-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolves #1388] Handle failures gracefully in stack outputs #1391
Conversation
This adds a unit test demonstrating the behaviour of a badly-formatted resolver.
This adds exception handling in the case of failures to parse the given arguments to !stack_output and !stack_output_external.
How does it look when you run it with a real template? Does it print a stack trace, or something more readable? |
If you provide a minimal Sceptre project setup that invokes the error, I'll run it at the command line to see how it feels compared to the original behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks for your work on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/integration-tests
This adds exception handling in the case of failures to parse the given arguments to
!stack_output
and!stack_output_external
.PR Checklist
[Resolve #issue-number]
.poetry run tox
) are passing.poetry run pre-commit run --all-files
).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit