Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a sanity check on locations to prevent a crash #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rickprice
Copy link

Sanity check locations value in json dictionary to handle when the value does not exist.

Fix for #55
Fix for #37

@Scarygami
Copy link
Owner

Scarygami commented Mar 19, 2023

Thanks for taking care of this topic.
The issue I see with this approach, is that this will just create empty output files, when choosing the wrong input file.
I think it would be useful to put out a message in case locations is missing, to make clear why this has happened.

@Forge36
Copy link

Forge36 commented Aug 26, 2023

While this prevents the crash it doesn't parse the data. I'm with Scarygami that this doesn't get at the heart of the request for those issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants