Redshift patch #170
Open
Redshift patch #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring my development branch up-to date
Added all the datatypes and their aliases
| {%- elif datatype == 'FLOAT' %} CAST('0' as FLOAT) as {{ alias }} | ||
| {%- elif datatype == 'BOOLEAN' %} CAST('FALSE' as BOOLEAN) as {{ alias }} | ||
| {%- elif datatype == 'VARBINARY' %} 'NULL'::varbyte as {{ alias }} | ||
| {%- elif datatype == 'VARCHAR' or datatype == 'CHARACTER VARYING' or datatype == 'NVARCHAR' or datatype == 'TEXT' %} '{{unknown_value__STRING}}' as {{ alias }} |
There was a problem hiding this comment.
please group the datatypes into array for ease of extending this code in the future, see line 363.
Same for the following code lines.
Change hash_datatype from BINARY(16) to VARCHAR(32) for Redshift Compatibility
change hardcoded default hash_datatype to varchar(32) for redshift macros
Added an Adapter Dispatch
Changed Snowflake aliases to "{{ alias }}"
Tkirschke patch 3 to Redshift Patch
Added double quotes to the keys and a case wise handling so that the hashdiffs do not get double quoted. Added these changes as a snowflake version
Added more exceptions to the if clause
|
Hi @thoffmann-sf , Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all RedShift datatypes to the Ghost_Records_per_Datatype macro and fixed the other macros that were broken for RedShift and Postgres