Mssql #100
Open
Mssql #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cmettler, and thanks for this Pull Request! We will review it as soon as our capacities allow it. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have continued to make adjustments to the previous sqlserver branch.
Mainly, the 'all in' conditions were changed to left outer joins, as 'not in' does not perform very well on SQL Server.
Additionally, I joined the ghost record to the ref_hub in the reference table in case some ref_sat entries get deleted.
I added a local variable, 'convert_to_hex_style', in the hash_standardization to determine whether '0x' should be part of the string hashkey or not, as I did not know how this was handled in the other implementations.
Currently i have only checked this implementation with an sql server adjusted datavault4dbt-snowflake-demo with full+incremental run and md5 with char(32) and binary(16) data types