Skip to content
This repository has been archived by the owner on Sep 13, 2021. It is now read-only.

fixes build for angular material 10.2 #156

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

zualexander
Copy link
Contributor

with angular 10.2. the build breaks:

`ERROR in node_modules/saturn-datepicker/datepicker/datepicker.d.ts:57:22 - error TS2420: Class 'SatDatepicker' incorrectly implements interface 'CanColor'.
Property 'defaultColor' is missing in type 'SatDatepicker' but required in type 'CanColor'.

57 export declare class SatDatepicker implements OnDestroy, CanColor {
~~~~~~~~~~~~~

node_modules/@angular/material/core/common-behaviors/color.d.ts:15:5
15 defaultColor: ThemePalette | undefined;
~~~~~~~~~~~~
'defaultColor' is declared here.`

@zualexander
Copy link
Contributor Author

pls tell me if I did something wrong, or I should adapt the PR :)

@itstueben
Copy link

closes #157

@zualexander
Copy link
Contributor Author

do you want me to change the 'defaultColor' to an '@input'?

@raphael22
Copy link

@SaturnTeam Could you have a look ? Thanks !

@itstueben
Copy link

@georgms
Copy link

georgms commented Oct 6, 2020

This awesome date picker is currently unusable with Angular Material 10. It would be so great if you could merge this simple change so we can upgrade our apps to Angular Material 10.

@SaturnTeam SaturnTeam merged commit 5b5a4b1 into SaturnTeam:master Oct 6, 2020
@gualtierim
Copy link

Hi, I tried to install the new version with npm (8.0.6), but I didn't found it. Can you release the new version? Thanks to great work done!

@zualexander
Copy link
Contributor Author

I'm sorry, I'm not a contributor of this repo, I just added this quickfix as a PR.
@SaturnTeam can you do the release? :)

@georgms
Copy link

georgms commented Oct 18, 2020

@SaturnTeam Thanks for merging the fix. Any ETA for a new NPM release including this? Really looking forward to it so I can upgrade our app to Angular 10.

@davidoween
Copy link

I use Angular 10, and i have the same problem. any solution?

@georgms
Copy link

georgms commented Feb 23, 2021 via email

@davidoween
Copy link

We switched back to the builtin Angular Material date picker which, starting with version 10, also supports date ranges which was our initial reason to use the Saturn Date picker. davidoween [email protected] schrieb am Di., 23. Feb. 2021, 09:57:

I use Angular 10, and i have the same problem. any solution? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#156 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVZVIWUWH3RCOD5DYI6QJ3TANUW7ANCNFSM4Q6DNQ3A .

I need a inline datepicker .

there is no solution?

@nathan-konv
Copy link

Not sure and will verify tomorrow. But I got the feeling there are 2 published packages: saturn-datepicker
and saturn-datepicker-ext.
The latter one seems to have the fix but not the former one which I actually use.
If anybody has a chance to try before I do. I am off for today :)

@nathan-konv
Copy link

And it seems that @angular/material v11.2.2 now offers to pick a range: https://material.angular.io/components/datepicker/overview#date-range-selection

@nathan-konv
Copy link

I confirm. I used the npm package saturn-datepicker-ext instead of saturn-datepicker and everything is working fine on my end.
Will replace that by the newly supported range picker from angular material v11.2.2 soon.

@zualexander zualexander deleted the fixes-for-angular-10.1 branch March 9, 2021 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants