test rex using values from global parameters #17043
Conversation
pondrejk
added
Stream
| for key_val in key_vals: | ||
| param, new_value = tuple(key_val.split('=')) if '=' in key_val else (key_val, None) | ||
| existing_params = target_sat.api.CommonParameter().search(query={'search': f'name={param}'}) | ||
| if len(existing_params) > 0: |
There was a problem hiding this comment.
Can this be >1? Should it? Should we assert <=1?
|
|
||
|
|
||
| @pytest.fixture | ||
| def multi_setting_update(request, target_sat): |
There was a problem hiding this comment.
Have you decided to keep the old fixture, even though this is more generalized, for backwards compatibility?
| @@ -311,6 +311,96 @@ def test_positive_run_job_effective_user( | |||
| } | |||
| ) | |||
|
|
|||
| @pytest.mark.tier3 | |||
| @pytest.mark.parametrize( | |||
| 'multi_global_param_update', | |||
There was a problem hiding this comment.
To self-answer the question I've had: why use global parameters when there are global settings just for this? I think global parameters are used in templating (to setup execution) and global settings are used to actually execute.
| 'multi_global_param_update', | ||
| [ | ||
| [ | ||
| 'remote_execution_effective_user', |
There was a problem hiding this comment.
param, new_value = tuple(key_val.split('=')) if '=' in key_val else (key_val, None)
So here, you save the parameters and restore them later in cleanup. Only to later set them to some value in the test itself. Isn't it better to just set them to desired value here? Or, if you need randomness, in a separate fixture?
| param_object.value = new_value | ||
| param_object.update({'value'}) | ||
| else: | ||
| param_object = target_sat.api.CommonParameter(name=param, value=new_value).create() |
There was a problem hiding this comment.
Should we check for new_value is not None here?
| else: | ||
| param_object = target_sat.api.CommonParameter(name=param, value=new_value).create() | ||
| cleanup = True | ||
| default_param_value = new_value |
There was a problem hiding this comment.
Why? We do cleanup anyway.
Problem Statement
mostly to cover SAT-28443, but also to check global params usage
Solution
note: It turned out the scenario needs global params and not global settings, but since I already wrote the multi_setting_update fixture, I left it there for potential future use
also stream has hickups with AKs, so holding of prt for now
Related Issues
SAT-28443