Skip to content

🚀 Add code validation workflow #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 28, 2025
Merged

🚀 Add code validation workflow #4

merged 10 commits into from
Aug 28, 2025

Conversation

@rahulpatidar0191
Copy link
Member

@rahulpatidar0191 rahulpatidar0191 commented Aug 27, 2025 •
edited by github-actions bot
Loading

  • Added code validation and cleaned up a few things
App Main branch This PR Redoc link Resource models
backend-integration Coverage Coverage - -

@rahulpatidar0191 rahulpatidar0191 self-assigned this Aug 27, 2025
@rahulpatidar0191
Copy link
Member Author

rahulpatidar0191 commented Aug 27, 2025

@lishanl I am thinking I'll move the content of howto to readme now, when we create a new app I can just remove that remove by using the shell script as I do with some other files already

@rahulpatidar0191 rahulpatidar0191 marked this pull request as draft August 27, 2025 21:23
@rahulpatidar0191 rahulpatidar0191 marked this pull request as ready for review August 27, 2025 21:45
@rahulpatidar0191
Copy link
Member Author

rahulpatidar0191 commented Aug 27, 2025

@lishanl I am thinking I'll move the content of howto to readme now, when we create a new app I can just remove that remove by using the shell script as I do with some other files already

Added

lishanl
lishanl approved these changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@lishanl lishanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

rename-integration.sh
echo ""
# 8. Remove the rename script from the newly created folder
if [ -f "rename-integration.sh" ]; then
rm "rename-integration.sh"
Copy link
Collaborator

@lishanl lishanl Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: the script can remove itself when it's being run?

Copy link
Member Author

@rahulpatidar0191 rahulpatidar0191 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :)

@rahulpatidar0191 rahulpatidar0191 merged commit 424c994 into main Aug 28, 2025
4 checks passed
@rahulpatidar0191 rahulpatidar0191 deleted the feature/code-validation branch August 28, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lishanl lishanl lishanl approved these changes

@ponty33 ponty33 Awaiting requested review from ponty33

Assignees

@rahulpatidar0191 rahulpatidar0191

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rahulpatidar0191 @lishanl