Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Disable stoping of addon after finding vulnerability #20

Merged
merged 20 commits into from
Oct 19, 2023
Merged

Feature: Disable stoping of addon after finding vulnerability #20

merged 20 commits into from
Oct 19, 2023

Conversation

TomerPacific
Copy link
Contributor

Fixes #19

  • Added UI (checkbox) to allow users to choose to keep the uploading files after a vulnerability is found
  • Added logic to set/get this flag in configurations and in other places
  • Modified condition inside FileUploadAttackExecutor to consider this flag

@TomerPacific TomerPacific mentioned this pull request Oct 13, 2023
Closed
@preetkaran20 preetkaran20 marked this pull request as ready for review October 13, 2023 20:46
@preetkaran20
Copy link
Member

@TomerPacific I think you removed the logic related to using the flag shouldSendRequestsAfterFindingVulnerability. please add that. The place where you added the logic is correct.

thanks,
Karan

@TomerPacific
Copy link
Contributor Author

@preetkaran20 - Yes, I removed the logic per your recommendations. I'll add the logic back.

@TomerPacific
Copy link
Contributor Author

TomerPacific commented Oct 15, 2023 •
edited
Loading

@preetkaran20 - Please review again.
Also, if you could add the hacktoberfest-accepted label.

@preetkaran20
Copy link
Member

I think UI can be changed a little bit like below:

image

i.e. changing label and checkbox order.

can we rename label of checkbox to something like Keep exploiting after discovery. or Keep exploiting vulnerabilities after discovery or Keep exploiting after discovering vulnerabilities etc. thoughts?
`

@TomerPacific
Copy link
Contributor Author

@preetkaran20 - I'll change the UI according to your recommendation.

@preetkaran20
Copy link
Member

@TomerPacific changes looks good to me. Just one thing, please align the UI flag to left and make label first and then the checkbox as shown in the below image:
image

preetkaran20
preetkaran20 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@preetkaran20 preetkaran20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Thanks for the changes.

@TomerPacific
Copy link
Contributor Author

@preetkaran20 - Still working on the changes, am not finished. Will let you know when I am done.

@TomerPacific
Copy link
Contributor Author

@preetkaran20 - I think I managed to produce the UI changes you requested.

owasp

Let me know if anything else is necessary.

preetkaran20
preetkaran20 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@preetkaran20 preetkaran20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @TomerPacific !!!
Thanks for the PR.

@preetkaran20 preetkaran20 merged commit bc4ed01 into SasanLabs:main Oct 19, 2023
1 check passed
@TomerPacific TomerPacific deleted the feature/stop-addon-vulnerability branch October 20, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preetkaran20 preetkaran20 preetkaran20 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable stoping of addon after finding vulnerability
2 participants
@TomerPacific @preetkaran20