(Nora v2.0.0-stable major update) Merge pull request #152 from Sandak…

…an/major-release

.erb/configs/webpack.config.renderer.dev.ts

@@ -75,7 +75,6 @@ const configuration: webpack.Configuration = {
               importLoaders: 1,
             },
           },
-          'sass-loader',
           {
             loader: 'postcss-loader',
             options: {
@@ -92,7 +91,6 @@ const configuration: webpack.Configuration = {
         use: [
           'style-loader',
           'css-loader',
-          'sass-loader',
           {
             loader: 'postcss-loader',
             options: {

.erb/configs/webpack.config.renderer.prod.ts

@@ -57,7 +57,6 @@ const configuration: webpack.Configuration = {
               importLoaders: 1,
             },
           },
-          'sass-loader',
           {
             loader: 'postcss-loader',
             options: {
@@ -74,7 +73,6 @@ const configuration: webpack.Configuration = {
         use: [
           MiniCssExtractPlugin.loader,
           'css-loader',
-          'sass-loader',
           {
             loader: 'postcss-loader',
             options: {

.erb/scripts/notarize.js

@@ -1,4 +1,4 @@
-const { notarize } = require('electron-notarize');
+const { notarize } = require('@electron/notarize');
 const { build } = require('../../package.json');
 
 exports.default = async function notarizeMacos(context) {

.eslintrc.js

@@ -7,26 +7,20 @@ module.exports = {
     'react/react-in-jsx-scope': 'off',
     'prettier/prettier': 'off',
     // custom eslint rules
-    'react/require-default-props': [0],
+    'react/require-default-props': 'off',
     'no-nested-ternary': 'off',
     'import/no-cycle': 'off',
     'import/no-named-as-default': 'off',
-    'no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
+    'no-unused-vars': 'off',
     'no-console': 'off',
     'no-undef': 'off',
     'prefer-const': 'warn',
-    'import/extensions': ['off'],
-    'react/function-component-definition': ['off'],
-    'default-param-last': ['off'],
+    'import/extensions': 'off',
+    'react/function-component-definition': 'off',
+    'default-param-last': 'off',
+    'import/prefer-default-export': 'off',
     'import/no-unresolved': [2, { caseSensitive: false }],
     radix: ['warn', 'as-needed'],
-    // '@typescript-eslint/naming-convention': [
-    //   'warn',
-    //   {
-    //     leadingUnderscore: 'allowSingleOrDouble',
-    //     trailingUnderscore: 'allowSingleOrDouble',
-    //   },
-    // ],
     'react/no-unescaped-entities': [
       'error',
       {
@@ -46,6 +40,14 @@ module.exports = {
     'no-restricted-syntax': 'off',
     'import/named': 'off',
   },
+  overrides: [
+    {
+      files: ['**/*.d.ts'],
+      rules: {
+        'no-use-before-define': 'off',
+      },
+    },
+  ],
   parserOptions: {
     ecmaVersion: 2020,
     sourceType: 'module',

.github/contributing.md

@@ -0,0 +1,40 @@
+# Contributing Guide for Nora
+
+First off, Thank you for deciding to contribute to Nora. It's people like you that make Nora live a long time.
+
+Following these guidelines helps to communicate that you respect the time of the developers managing and developing this open source project. In return, they should reciprocate that respect in addressing your issue, assessing changes, and helping you finalize your pull requests.
+
+## Types of contributions
+
+> Nora is an open source project and I'd love to receive contributions from the community. These can be bug reports, feature requests or writing code to resolve already existing issues.
+
+## Ground Rules
+
+> **Responsibilities**
+>
+> - Ensure compatibility for Windows and Linux for every change that's accepted.
+> - Create issues for any major changes and enhancements that you wish to make. Discuss things transparently and get community feedback.
+> - Keep feature versions as small as possible, preferably one new feature per version.
+
+## Getting started
+
+> First, always check the Issues panel whether your issue has been already added by another contributor.
+
+#### **For something that is bigger than a few lines:**
+
+> 1.  Create your own fork of the code
+> 2.  Do the changes in your fork
+> 3.  If you like the change and think the project could use it, create a pull request.
+> 4.  Be sure you have followed the code style for the project.
+
+### How to report a bug
+
+> You can follow the [bug report template](./ISSUE_TEMPLATE/bug_report.md) when adding a new bug report for Nora.
+
+### How to suggest a feature or enhancement
+
+> You can follow the [feature request template](./ISSUE_TEMPLATE/bug_report.md) when adding new feature request for Nora.
+
+<br>
+
+##### Created this template with the help of [Nayafia's Contributing Template](https://github.com/nayafia/contributing-template/blob/master/CONTRIBUTING-template.md).

.github/pull_request_template.md

@@ -0,0 +1,7 @@
+# Fixes
+
+## Proposed Changes
+
+-
+-
+-

.github/workflows/codeql-analysis.yml

@@ -9,14 +9,14 @@
 # the `language` matrix defined below to confirm you have the correct set of
 # supported CodeQL languages.
 #
-name: "CodeQL"
+name: 'CodeQL'
 
 on:
   push:
-    branches: [ "master" ]
+    branches: ['master']
   pull_request:
     # The branches below must be a subset of the branches above
-    branches: [ "master" ]
+    branches: ['master']
   schedule:
     - cron: '15 2 * * 3'
 
@@ -32,41 +32,40 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        language: [ 'javascript' ]
+        language: ['javascript']
         # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
         # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
 
     steps:
-    - name: Checkout repository
-      uses: actions/checkout@v3
+      - name: Checkout repository
+        uses: actions/checkout@v3
 
-    # Initializes the CodeQL tools for scanning.
-    - name: Initialize CodeQL
-      uses: github/codeql-action/init@v2
-      with:
-        languages: ${{ matrix.language }}
-        # If you wish to specify custom queries, you can do so here or in a config file.
-        # By default, queries listed here will override any specified in a config file.
-        # Prefix the list here with "+" to use these queries and those in the config file.
-
-        # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
-        # queries: security-extended,security-and-quality
+      # Initializes the CodeQL tools for scanning.
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v2
+        with:
+          languages: ${{ matrix.language }}
+          # If you wish to specify custom queries, you can do so here or in a config file.
+          # By default, queries listed here will override any specified in a config file.
+          # Prefix the list here with "+" to use these queries and those in the config file.
 
-
-    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
-    # If this step fails, then you should remove it and run the build manually (see below)
-    - name: Autobuild
-      uses: github/codeql-action/autobuild@v2
+          # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+          # queries: security-extended,security-and-quality
 
-    # ℹ️ Command-line programs to run using the OS shell.
-    # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+      # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+      # If this step fails, then you should remove it and run the build manually (see below)
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v2
 
-    #   If the Autobuild fails above, remove it and uncomment the following three lines. 
-    #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+      # ℹ️ Command-line programs to run using the OS shell.
+      # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
 
-    # - run: |
-    #   echo "Run, Build Application using script"
-    #   ./location_of_script_within_repo/buildscript.sh
+      #   If the Autobuild fails above, remove it and uncomment the following three lines.
+      #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
 
-    - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v2
+      # - run: |
+      #   echo "Run, Build Application using script"
+      #   ./location_of_script_within_repo/buildscript.sh
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v2

.github/workflows/lint.yml

@@ -0,0 +1,36 @@
+name: Lint
+
+on:
+  # Trigger the workflow on push or pull request,
+  # but only for the main branch
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  run-linters:
+    name: Run linters
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out Git repository
+        uses: actions/checkout@v2
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: 18
+          check-latest: true
+
+      # ESLint and Prettier must be in `package.json`
+      - name: Install Node.js dependencies
+        run: npm ci
+
+      - name: Run linters
+        uses: wearerequired/lint-action@v2
+        with:
+          eslint: true
+          prettier: true

.gitignore

@@ -23,3 +23,4 @@ npm-debug.log.*
 *.css.d.ts
 *.sass.d.ts
 *.scss.d.ts
+lint_results.txt

.prettierignore

@@ -0,0 +1,7 @@
+**/.git
+**/.svn
+**/.hg
+**/node_modules
+**/.erb/dll
+**/thunder-tests
+**/release

.prettierrc

@@ -0,0 +1,11 @@
+{
+  "singleQuote": true,
+  "overrides": [
+    {
+      "files": [".prettierrc", ".eslintrc"],
+      "options": {
+        "parser": "json"
+      }
+    }
+  ]
+}

.vscode/settings.json

@@ -3,6 +3,7 @@
     "acoustid",
     "aeiou",
     "apic",
+    "Brainz",
     "Deezer",
     "ecfg",
     "Fashni",
@@ -18,6 +19,7 @@
     "Resyncing",
     "RIELL",
     "Spicetify",
+    "sspai",
     "unmaximize",
     "unsynced",
     "webm",

LICENSE.txt

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2022 Sandakan Nipunajith
+Copyright (c) 2023 Sandakan Nipunajith
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal