Skip to content

Commit

Permalink
Merge pull request #114 from Sandakan/minor-release
Browse files Browse the repository at this point in the history
v1.1.0-stable update for Nora.
  • Loading branch information
Sandakan authored Feb 26, 2023
2 parents db4394f + 888f3f6 commit 29cd1df
Show file tree
Hide file tree
Showing 164 changed files with 5,318 additions and 3,065 deletions.
2 changes: 1 addition & 1 deletion .erb/configs/webpack.config.renderer.dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const configuration: webpack.Configuration = {
},
// Images
{
test: /\.(png|svg|jpg|jpeg|gif)$/i,
test: /\.(png|svg|jpg|jpeg|gif|webp)$/i,
type: 'asset/resource',
},
{
Expand Down
2 changes: 1 addition & 1 deletion .erb/configs/webpack.config.renderer.prod.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const configuration: webpack.Configuration = {
},
// Images
{
test: /\.(png|svg|jpg|jpeg|gif)$/i,
test: /\.(png|svg|jpg|jpeg|gif|webp)$/i,
type: 'asset/resource',
},
{
Expand Down
10 changes: 4 additions & 6 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,7 @@ module.exports = {
'import/no-extraneous-dependencies': 'off',
// Since React 17 and typescript 4.1 you can safely disable the rule
'react/react-in-jsx-scope': 'off',
'prettier/prettier': [
'warn',
{
endOfLine: 'auto',
},
],
'prettier/prettier': 'off',
// custom eslint rules
'react/require-default-props': [0],
'no-nested-ternary': 'off',
Expand All @@ -24,6 +19,7 @@ module.exports = {
'react/function-component-definition': ['off'],
'default-param-last': ['off'],
'import/no-unresolved': [2, { caseSensitive: false }],
radix: ['warn', 'as-needed'],
// '@typescript-eslint/naming-convention': [
// 'warn',
// {
Expand All @@ -47,6 +43,8 @@ module.exports = {
},
],
'react/jsx-filename-extension': 'off',
'no-restricted-syntax': 'off',
'import/named': 'off',
},
parserOptions: {
ecmaVersion: 2020,
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,4 @@ npm-debug.log.*
*.css.d.ts
*.sass.d.ts
*.scss.d.ts
src/main/core/toggleBlacklistFolders.ts
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<h1 align="center">
<img class="logo" src="assets/images/png/logo_light_mode.png" width="50px">
<img class="logo" src="assets/images/webp/logo_light_mode.webp" width="50px">
<p>Nora Player</p>
</h1>
<div align="center">
<img alt="GitHub all releases" src="https://img.shields.io/github/downloads/Sandakan/Nora/total?label=all%20time%20downloads&style=for-the-badge">
<img alt="GitHub release (latest by date)" src="https://img.shields.io/github/downloads/Sandakan/Nora/v1.0.0-stable/total?style=for-the-badge">
<img alt="GitHub release (latest by date)" src="https://img.shields.io/github/downloads/Sandakan/Nora/v1.1.0-stable/total?style=for-the-badge">
<img alt="GitHub package.json version" src="https://img.shields.io/github/package-json/v/Sandakan/Nora?color=blue&label=latest%20version&style=for-the-badge">
<a href="https://github.com/Sandakan/Nora/blob/master/LICENSE"><img alt="GitHub license" src="https://img.shields.io/github/license/Sandakan/Nora?style=for-the-badge"></a>
<a href="https://github.com/Sandakan/Nora/issues"><img alt="GitHub issues" src="https://img.shields.io/github/issues/Sandakan/Oto-Music-for-Desktop?style=for-the-badge"></a>
Expand Down
5 changes: 5 additions & 0 deletions assets/assets.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ declare module '*.jpg' {
export default content;
}

declare module '*.webp' {
const content: string;
export default content;
}

declare module '*.scss' {
const content: Styles;
export default content;
Expand Down
Binary file removed assets/images/other/error.png
Binary file not shown.
Binary file removed assets/images/other/song_cover_default1.png
Binary file not shown.
Binary file removed assets/images/png/album_cover_default.png
Binary file not shown.
Binary file removed assets/images/png/artist_cover_default.png
Binary file not shown.
Binary file removed assets/images/png/default_artist_cover.png
Binary file not shown.
Binary file removed assets/images/png/empty-folder.png
Binary file not shown.
Binary file removed assets/images/png/favorites-playlist-icon.png
Binary file not shown.
Binary file removed assets/images/png/history-playlist-icon.png
Binary file not shown.
Binary file removed assets/images/png/logo_light_mode.png
Binary file not shown.
Binary file removed assets/images/png/playlist_cover_default.png
Binary file not shown.
Binary file removed assets/images/png/sl-flag.png
Binary file not shown.
Binary file removed assets/images/png/song_cover_default.png
Binary file not shown.
Binary file added assets/images/webp/album_cover_default.webp
Binary file not shown.
Binary file added assets/images/webp/artist_cover_default.webp
Binary file not shown.
Binary file added assets/images/webp/empty-folder.webp
Binary file not shown.
Binary file added assets/images/webp/favorites-playlist-icon.webp
Binary file not shown.
Binary file added assets/images/webp/genre-cover-default.webp
Binary file not shown.
Binary file added assets/images/webp/history-playlist-icon.webp
Binary file not shown.
Binary file added assets/images/webp/logo_light_mode.webp
Binary file not shown.
Binary file added assets/images/webp/playlist_cover_default.webp
Binary file not shown.
Binary file added assets/images/webp/sl-flag.webp
Binary file not shown.
Binary file added assets/images/webp/song_cover_default.webp
Binary file not shown.
Binary file not shown.
3 changes: 2 additions & 1 deletion assets/styles/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ html {
font-variation-settings: 'FILL' 1;
}

.material-icons-round-outlined {
.material-icons-round-outlined,
.material-icons-round.material-icons-round-outlined {
font-family: 'Material Icons Round';
font-variation-settings: 'FILL' 0;
}
Expand Down
57 changes: 53 additions & 4 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,62 @@
<h1> Change Log</h1>
<h1 align="center"> Change Log</h1>

<h3>The latest version (v1.0.0-stable) contains a lot of new features and improvements. As always expect some bugs in the app.</h3>
<h3>The latest version (v1.1.0-stable) contains a lot of new features and improvements. As always expect some bugs in the app.</h3>

<br>

<img src="assets\other\release artworks\whats-new-v1.0.0-stable.webp">
<img src="assets\other\release artworks\whats-new-v1.1.0-stable.webp">

<br>
<ul>
<li class="version"> <h3> v1.1.0-stable - ( 26<sup>th</sup> of February 2023 )</h3>
<ul>
<li> <h4>🎉 New Features and Features</h4>
<ul>
<li>Support for editing audio files outside the library.</li>
<li>Support for further customizations when downloading song metadata from the internet.</li>
<li>Support for folder blacklisting and improvements for song blacklisting.</li>
<li>Added an indicator to show whether an artist is liked or not.</li>
<li>Added new keyboard shortcuts to go to forward and backward pages and to change app theme.</li>
<li>New BlacklistFolderConfirmPrompt and improvements for BlacklistSongConfirmPrompt.</li>
<li>Support for audio seeking or changing the volume through mouse scrolling by hovering over the seek bar and the volume bar.</li>
<li>Support for caching song data played from outside the library to improve performance when playing them again in the same session.</li>
</ul>
</li>
<li> <h4>🔨 Fixes and Improvements</h3>
<ul>
<li>Improvements for error handling related to network requests.</li>
<li>Removed Backlisted Songs section in the Settings Page.</li>
<li>Fixed a bug where Mini Player show un-scrollable unsynchronized lyrics.</li>
<li>Fixed a bug where artworks without 1:1 aspect ratio breaks the alignment of how the songs are displayed.</li>
<li>Added a new sort option for SongsPage and FoldersPage to sort blacklisted and whitelisted folders and songs.</li>
<li>Fixed a bug where temp artworks aren't getting cleaned up after the app closes.</li>
<li>Fixed a bug where artists aren't being sorted properly.</li>
<li>Fixed some bugs where some pages not updating its contents according to data events.</li>
<li>Fixed a bug where removing a song doesn't trigger 'playlists' and 'genres' data events.</li>
<li>Fixed a bug where some artist sort options aren't working as expected.</li>
<li>Fixed a bug where toggling 'like song' in Song or SongCard doesn't get updated in the currentSongData and vice versa.</li>
<li>Fixed a bug where Artist not showing default artist cover when there is no artwork for an artist.</li>
<li>Fixed a bug where FoldersPage doesn't get updated when song gets deleted or added.</li>
<li>Fixed a bug where online lyrics is not being saved to the audio file.</li>
<li>Fixed a bug where some pages like HomePage, CurrentQueuePage not updating songs when a song gets blacklisted.</li>
<li>Reduced image file sizes by using them in webp format.</li>
<li>Removed change theme button on the title bar for production builds.</li>
<li>Updated Musixmatch Lyrics Disclaimer.</li>
</ul>
</li>
<li> <h4>🐜 Known Issues and Bugs</h4>
<ul>
<li>Sometimes users can get unexpected search results when using Search.</li>
<li>App theme will be changed when you change your system's theme even though you didn't select to use system theme in the app.</li>
<li>If a song is added next to the last song of the queue, the last song won't be played.</li>
<li>Sometimes adding a song to play next would only add it to the queue instead of adding it next to the current song.</li>
</ul>
</li>
</ul>
</li>

<br>

<li class="version"> <h3> v1.0.0-stable - ( 17<sup>th</sup> of February 2023 )</h3>
<ul>
<li><h4>🎉 New Features and Updates</h4>
Expand Down Expand Up @@ -253,7 +302,7 @@

<br/>

<li class="version"> v0.6.0-alpha - ( 24<sup>th</sup> of June 2022 )
<li class="version"> v0.6.0-alpha - ( 24<sup>th</sup> of June 2022 )
<ul>
<li> <h4>🎉 New Features and Features</h4>
<ul>
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "nora",
"productName": "Nora",
"description": "An elegant music player built using Electron and React. Inspired by Oto Music for Android by Piyush Mamidwar.",
"version": "1.0.0-stable",
"version": "1.1.0-stable",
"license": "MIT",
"appPreferences": {
"removeReactStrictMode": false,
Expand Down
98 changes: 93 additions & 5 deletions release-notes.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,102 @@
{
"latestVersion": {
"version": "1.0.0-stable",
"phase": "alpha",
"releaseDate": "2023 February 17",
"artwork": "/assets/other/release artworks/whats-new-v1.0.0-stable.webp",
"version": "1.1.0-stable",
"phase": "stable",
"releaseDate": "2023 February 26",
"artwork": "/assets/other/release artworks/whats-new-v1.1.0-stable.webp",
"importantNotes": [
"This update requires a full media library refresh to reduce the storage usage and to improve performance when accessing the library."
"This update can put your blacklisted songs again into your library. Sorry for the inconvenience.",
"Updated the Musixmatch Disclaimer Notice. Please read it before using the service."
]
},
"versions": [
{
"version": "1.1.0-stable",
"releaseDate": "2023 February 26",
"notes": {
"new": [
{ "note": "Support for editing audio files outside the library." },
{
"note": "Support for further customizations when downloading song metadata from the internet."
},
{
"note": "Support for folder blacklisting and improvements for song blacklisting."
},
{
"note": "Added an indicator to show whether an artist is liked or not."
},
{
"note": "Added new keyboard shortcuts to go to forward and backward pages and to change app theme."
},
{
"note": "New BlacklistFolderConfirmPrompt and improvements for BlacklistSongConfirmPrompt."
},
{
"note": "Support for audio seeking or changing the volume through mouse scrolling by hovering over the seek bar and the volume bar."
}
],
"fixed": [
{
"note": "Improvements for error handling related to network requests."
},
{ "note": "Removed Backlisted Songs section in the Settings Page." },
{
"note": "Fixed a bug where Mini Player show un-scrollable unsynchronized lyrics."
},
{
"note": "Fixed a bug where artworks without 1:1 aspect ratio breaks the alignment of how the songs are displayed."
},
{
"note": "Added a new sort option for SongsPage and FoldersPage to sort blacklisted and whitelisted folders and songs."
},
{
"note": "Fixed a bug where temp artworks aren't getting cleaned up after the app closes."
},
{ "note": "Fixed a bug where artists aren't being sorted properly." },
{
"note": "Fixed some bugs where some pages not updating its contents according to data events."
},
{
"note": "Fixed a bug where removing a song doesn't trigger 'playlists' and 'genres' data events."
},
{
"note": "Fixed a bug where some artist sort options aren't working as expected."
},
{
"note": "Fixed a bug where toggling 'like song' in Song or SongCard doesn't get updated in the currentSongData and vice versa."
},
{
"note": "Fixed a bug where Artist not showing default artist cover when there is no artwork for an artist."
},
{
"note": "Fixed a bug where FoldersPage doesn't get updated when song gets deleted or added."
},
{
"note": "Fixed a bug where online lyrics is not being saved to the audio file."
},
{
"note": "Fixed a bug where some pages like HomePage, CurrentQueuePage not updating songs when a song gets blacklisted."
},
{ "note": "Reduced image file sizes by using them in webp format." },
{ "note": "Removed change theme button on the title bar." },
{ "note": "Updated Musixmatch Lyrics Disclaimer." }
],
"knownIssues": [
{
"note": "Sometimes users can get unexpected search results when using Search."
},
{
"note": "App theme will be changed when you change your system's theme even though you didn't select to use system theme in the app."
},
{
"note": "If a song is added next to the last song of the queue, the last song won't be played."
},
{
"note": "Sometimes adding a song to play next would only add it to the queue instead of adding it next to the current song."
}
]
}
},
{
"version": "1.0.0-stable",
"releaseDate": "2023 February 17",
Expand Down
4 changes: 2 additions & 2 deletions release/app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion release/app/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "nora",
"productName": "Nora",
"version": "1.0.0-stable",
"version": "1.1.0-stable",
"description": "An elegant music player built using Electron and React. Inspired by Oto Music for Android by Piyush Mamidwar.",
"main": "./dist/main/main.js",
"author": {
Expand Down
2 changes: 1 addition & 1 deletion release/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion release/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "nora",
"productName": "Nora",
"version": "1.0.0-stable",
"version": "1.1.0-stable",
"description": "An elegant music player built using Electron and React. Inspired by Oto Music for Android by Piyush Mamidwar.",
"main": "./dist/main/main.js",
"author": {
Expand Down
Loading

0 comments on commit 29cd1df

Please sign in to comment.