Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The README.md and setup.py are updated to install missed dependencies. #836

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

lyubomyrferents
Copy link
Contributor

Description

This change is intended to fix the issue #830 Packages are missing during the setup run on the newly deployed system.

Resolves #830

How Has This Been Tested?

This change was tested locally on a newly deployed Ubuntu20 system.

To reproduce the #830 issue, please follow the steps mentioned in the Development section and note the following commands are failing:

pip3.8 install -U universum[p4]
pip install -U .[test]

Those failures are not observed with the proposed changes applied anymore.

README.md Outdated
@@ -40,14 +40,18 @@ and then use the commands listed below. Please note we use `venv` to properly se
python interpreter version and to isolate development environment from the system.

Prerequisites:
1. Install all of the VCS extras as described in the [Universum installation manual](
1. Make sure the libssl-dev and libcrypto++-dev packages are available in your environment.
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add indentation for this code piece to not break the list

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the README.md file.

@k-dovgan k-dovgan merged commit 920baf2 into Samsung:master Dec 14, 2023
4 of 5 checks passed
@lyubomyrferents lyubomyrferents deleted the issue_830_fix branch December 14, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packages are missing during the setup run on the newly deployed system.
2 participants