kernel/sched: fix logging after stack overflow #6622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritesh55555
force-pushed
the
stack_overflow_logfix
branch
from
2991b9b to
110ebbf
Compare
samsung-singh
approved these changes
Jan 8, 2025
Comment on lines
127
to
132
| if (*(uint32_t *)(rtcb->stack_base_ptr) != STACK_COLOR) { | ||
| dbg_noarg("############### STACK OVERFLOW at pid %d ", rtcb->pid); | ||
| lldbg_noarg("\n############### STACK OVERFLOW at pid %d ", rtcb->pid); | ||
| #if CONFIG_TASK_NAME_SIZE > 0 | ||
| dbg_noarg("(%s) ", rtcb->name); | ||
| lldbg_noarg("(%s) ", rtcb->name); | ||
| #endif | ||
| dbg_noarg("###################\n"); | ||
| lldbg_noarg("###################\n"); |
There was a problem hiding this comment.
It could cause log mix.
Because we will call the PANIC after this message, how about adding enter_critical_section?
ritesh55555
force-pushed
the
stack_overflow_logfix
branch
3 times, most recently
from
1c57080 to
be7f3e9
Compare
| @@ -88,6 +88,33 @@ | |||
| * Public Functions | |||
| ****************************************************************************/ | |||
|
|
|||
| /**************************************************************************** | |||
There was a problem hiding this comment.
Sorry but let's add this with new file, not here.
ritesh55555
force-pushed
the
stack_overflow_logfix
branch
2 times, most recently
from
f6ba762 to
b72722c
Compare
| /**************************************************************************** | ||
| * kernel/sched/sched_checkstackoverflow.c | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without |
There was a problem hiding this comment.
No need to add this license. Let's remove.
os/kernel/sched/Make.defs
Outdated
| @@ -60,7 +60,7 @@ CSRCS += sched_setscheduler.c sched_getscheduler.c | |||
| CSRCS += sched_yield.c sched_rrgetinterval.c sched_foreach.c | |||
| CSRCS += sched_lock.c sched_unlock.c sched_lockcount.c sched_self.c | |||
| CSRCS += sched_getaffinity.c sched_setaffinity.c | |||
| CSRCS += sched_getcpu.c | |||
| CSRCS += sched_getcpu.c sched_checkstackoverflow.c | |||
There was a problem hiding this comment.
The function is called with CONFIG_SW_STACK_OVERFLOW_DETECTION.
It means this file is valid with the config. Let's add conditional for this.
Or, remove the conditional at all c file, and in header, let's do like below
#ifdef CONFIG_XXX
void sched_checkstackoverflow(FAR struct tcb_s *rtcb);
#else
#define sched_checkstackoverflow(x)
#endif
b72722c to
89b1e5a
Compare
- This commit changes logging method from dbg to lldbg to print stack overflow information. This is done because after stack overflow, using dbg does not work because of more stack memory requirement. But in the lldbg case, it uses low level syslog, so it uses minimal stack memory.
ritesh55555
force-pushed
the
stack_overflow_logfix
branch
from
89b1e5a to
aaca92a
Compare
sunghan-chang
approved these changes
Jan 10, 2025
kishore-sn
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes logging method from dbg to lldbg to print stack overflow information. This is done because after stack overflow, using dbg does not work because of more stack memory requirement. But in the lldbg case, it uses low level syslog, so it uses minimal stack memory.
logs before:
logs after changing to lldbg: