os/drivers, os/mm: Modify mm_manage_allocfail to print alignment #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -149,7 +149,7 @@ static int mminfo_ioctl(FAR struct file *filep, int cmd, unsigned long arg) | |||
| #ifdef CONFIG_APP_BINARY_SEPARATION | |||
| case MMINFOIOC_MNG_ALLOCFAIL: | |||
| /* There is a single heap for user. So start and end indexes of heap are always 0. */ | |||
| mm_manage_alloc_fail(BASE_HEAP, 0, 0, ((struct mm_alloc_fail_s *)arg)->size, USER_HEAP | |||
| mm_manage_alloc_fail(BASE_HEAP, 0, 0, ((struct mm_alloc_fail_s *)arg)->size, ((struct mm_alloc_fail_s *)arg)->align, USER_HEAP | |||
There was a problem hiding this comment.
With this additional value - align, can we know this is failed because of alignment?
There was a problem hiding this comment.
Added more logic for this. Please review.
Modify mm_manage_allocfail API to print alignment value for which the allocation has failed. Also, print the largest available free node with the required alignment. Sample output: Memalign case ================================================================= mm_manage_alloc_fail: Allocation failed from user heap. mm_manage_alloc_fail: - requested size 524288 mm_manage_alloc_fail: - requested alignment 131072 mm_manage_alloc_fail: - caller address = 0x0e16d1c1 mm_manage_alloc_fail: - largest un-aligned free size : 655344 mm_manage_alloc_fail: - largest algined free size : 524272 mm_manage_alloc_fail: - total free size : 1524896 ================================================================= Malloc case ================================================================= mm_manage_alloc_fail: Allocation failed from user heap. mm_manage_alloc_fail: - requested size 524288 mm_manage_alloc_fail: - caller address = 0x0e16d1bd mm_manage_alloc_fail: - largest free size : 476208 mm_manage_alloc_fail: - total free size : 476288 ================================================================= Signed-off-by: Kishore S N <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify mm_manage_allocfail API to print alignment value for which the allocation has failed.