Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password location markup, batch 1-50 #93

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Password location markup, batch 1-50 #93

merged 6 commits into from
Mar 5, 2024

Conversation

Yullia
Copy link
Contributor

@Yullia Yullia commented Mar 3, 2024

No description provided.

babenek
babenek reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sugggested true cases

meta/1d8ec728.csv Outdated Show resolved Hide resolved
meta/1d8ec728.csv Outdated Show resolved Hide resolved
meta/106c7cd2.csv Outdated Show resolved Hide resolved
meta/106c7cd2.csv Outdated Show resolved Hide resolved
meta/106c7cd2.csv Outdated Show resolved Hide resolved
meta/0b0a8cd6.csv Outdated Show resolved Hide resolved
babenek
babenek reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback for false

meta/1d8ec728.csv Outdated Show resolved Hide resolved
meta/1d8ec728.csv Outdated Show resolved Hide resolved
meta/1d8ec728.csv Outdated Show resolved Hide resolved
meta/177cf0f9.csv Outdated Show resolved Hide resolved
meta/16fc0238.csv Outdated Show resolved Hide resolved
meta/02dfa7ec.csv Outdated Show resolved Hide resolved
meta/00408ef6.csv Outdated Show resolved Hide resolved
meta/00408ef6.csv Outdated Show resolved Hide resolved
meta/0064e882.csv Outdated Show resolved Hide resolved
meta/0064e882.csv Outdated Show resolved Hide resolved
babenek
babenek reviewed Mar 5, 2024
View reviewed changes
meta/14a53c5a.csv Outdated Show resolved Hide resolved
babenek
babenek reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback markup

meta/0b0a8cd6.csv Outdated Show resolved Hide resolved
@babenek babenek self-requested a review March 5, 2024 11:23
babenek
babenek approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@babenek babenek requested review from xDizzix, iuriimet, csh519 and kmnls March 5, 2024 11:23
@babenek babenek marked this pull request as ready for review March 5, 2024 11:32
@babenek babenek requested a review from a team as a code owner March 5, 2024 11:32
@babenek babenek merged commit c38da9d into Samsung:main Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babenek babenek babenek approved these changes

@xDizzix xDizzix xDizzix approved these changes

@iuriimet iuriimet Awaiting requested review from iuriimet

@csh519 csh519 Awaiting requested review from csh519

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yullia @xDizzix @babenek