fix: A lost trigger response hides an already-running queued agent - #1012
Open
sam-saffron-jarvis wants to merge 1 commit into
Open
fix: A lost trigger response hides an already-running queued agent#1012sam-saffron-jarvis wants to merge 1 commit into
sam-saffron-jarvis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
queue_agenttrigger response against/v2/runs?job_id=...using a detached, two-second context.wait_for_jobsbefore retrying.Why this is high-value
The jobs server commits and wakes a queued run before writing the trigger response. A cancelled turn or transient loopback connection failure could therefore hide an expensive agent that was already queued or running. Jarvis could then retry, launch duplicate work, and lose the original run's handle and result. Reconciliation keeps the existing run observable without retriggering.
Validation
go build ./...go test ./internal/tools -count=1go test -race ./internal/tools -run 'TestQueueAgent(RecoversRunAfterLostTriggerResponse|PreservesJobIDWhenTriggerCannotBeReconciled)$' -count=1HOME=<clean temp dir> go test ./...git diff --checkA first
go test ./...under the agent's populated home exposed two unrelatedcmdskill-discovery tests that omit their temporary project skill when the global 31-skill catalog exceeds the configured display limit. Both tests, and the full suite, pass with a clean temporaryHOMEmatching CI isolation.