Issue #671: MatChipSet.SelectedChips should match on Label, not MatCh… #672
Conversation
Mentioned that internet access is required in Prerequisites.
…ts-with-docker Simplify deploying js/css
…? is true or false since it triumphs the checked/ not checked state
…osition immediately visible
Update README.md
…d in Prerequisites) SamProf#610 (Thanks to [rokx](https://github.com/rokx))
Checkbox indeterminate state fixes SamProf#533, fixes SamProf#658
…MatBlazor into stefanloerwald-immediate-slider # Conflicts: # src/MatBlazor/wwwroot/dist/matBlazor.js
- Changed DOM and JS for many components, because of changes in MDC Web 7.0.0 - Fixed: Floating label in Outlined MatTextField-based components - Fixed Validation via EditContext colors
Fixed a null reference exception.
…the hoistToMenu call in matSelect.js, as the full width of the menu must relate to the correct parent.
…t MatChip hash.
…anloerwald](https://github.com/stefanloerwald)) Added - if FullWidth is false - hoistToBody returned
- PR: Cleanup SamProf#673 (Thanks to [stefanloerwald](https://github.com/stefanloerwald)) - PR: Table Re-Rendering Fix SamProf#692 (Thanks to [erlendp](https://github.com/erlendp)) - PR: Custom Drawer Width Demo. Readme contribution updates SamProf#701
|
Why MatChip instance is not good? |
…lder SamProf#677 (Thanks to [stefanloerwald](https://github.com/stefanloerwald))
…nto PA4WD-ResponsiveMenu
…ller screens. SamProf#684 (Thanks to [PA4WD](https://github.com/PA4WD))
Spaces in folder name's break DemoContentGenerator.Generate()
…te() SamProf#685 (Thanks to [PA4WD](https://github.com/PA4WD))
Language improvements
PR SamProf#642. Fixes SamProf#619 Validation styles for outlined Text fields
Remove event on Dispose instead of adding one
…lds SamProf#702 (Thanks to [enkodellc](https://github.com/enkodellc)) - PR: Remove event on Dispose instead of adding one SamProf#703 (Thanks to [LeoVen](https://github.com/LeoVen))
|
@petert1401 , looks like there are merge conflicts 😱 |
Fix null reference exception for multi column filtering in MatTable
…t MatChip hash.
…ips' into Issue#671_Fix_ChipSet_SelectedChips
DeepCode's analysis on #059947 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
|
@Christian-Oleson Merge conflicts resolved (by pulling latest code from MatBlazor.master) |
|
@petert1401 , |
|
@Christian-Oleson, when I originally submitted this, it was a simple 2-line change to MatChipset.cs Because of delays in reviewing & merging, that cascaded into 135 file merges - one of which is the deepcode issue with MatSlider.cs. It's nothing to do with the original commit to MatChipset and I don't see why I should be expected to resolve it - it should've been resolved when the MatSlider code was last updated. Maybe the easiest thing to do would be to ditch this pull request and redo the original 2-line change on a fresh branch. Then review & merge it promptly. |
Unfortunately, I don't have anything to do with that portion. The deepcode failures are regarding an uncaught promise, and an unnecessary assignment. If you could fix those two items, at least it would no longer be blocking this PR. Also, right now this PR is pointed at master. It should be pointed to Dev |
|
@Christian-Oleson, no sorry, that uncaught promise is nothing to do with the code I've submitted, neither is the unnecessary assignment - they should be fixed by the original authors. Maybe the cause is that the PR is pointing at master instead of dev? I suggest you ditch this PR & redo the 2-line fix on a fresh branch. |
…ip hash.