-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatAutocomplete new component #550
base: develop
Are you sure you want to change the base?
Conversation
Hi @sandrohanea I am liking the look of this new AutoComplete :) is there an eta on it? |
Hi @Gareth064 |
That's great dude :) There is 1.5 bugs in MatAutoCompleteList which I was wondering if you could comment on in regards of how the behaviour is handled in this new version. They are #577 and #592 Also I had mentioned about enabling a Vertical scroll on the list via #587. What do you think about that? I have an app that is fully MatBlazor with the exception of the Auto Complete list component because of those first 2 bug. So I am looking forward to this new one so I can update my app so everything looks great 👍 |
handle backspace and tab key events
…eature/MatAutocomplete
resolve merge conflicts
I couldn't manage to finish it but I got help from @dbereghici so it's ready for review now. Thanks again @dbereghici ! |
@Gareth064 , |
Any chance this will be merged anytime soon? |
I see conflicts, so I doubt it. |
I fixed the conflicts. |
Many thanks, @sandrohanea. I'll help with documentation and some samples once this is merged in. |
This new component is based on MatInputTextComponent so all properties from the text input will be on this and usable(e.g. Disabled, etc).
I thought to keep the SelectedItem from MatAutocompleteList as I saw a lot of people are using it(previously named Value). Now Value will be the text and SelectedItem the item in the list which was selected either with the mouse or with the keyboard( Arrows + Enter).
I added IAutocompleteItemsSource to offer the possibility to use this component with a backend filtering instead of filtering on the UI in the component.