Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/textlint ci #28

Merged
merged 16 commits into from
Mar 22, 2019
Merged

Feature/textlint ci #28

merged 16 commits into from
Mar 22, 2019

Conversation

coord-e
Copy link
Contributor

@coord-e coord-e commented Mar 15, 2019 •
edited
Loading

Fix #25, #24

@coord-e coord-e added the enhancement New feature or request label Mar 15, 2019
@coord-e
Copy link
Contributor Author

coord-e commented Mar 15, 2019

yarn run textfix or yarn run textlint-fix or yarn run fix ... 🤔

Sakuten-Automation
Sakuten-Automation reviewed Mar 16, 2019
View reviewed changes
docs/misc/wiki-usage/how-to-add-post.md Outdated
@@ -13,7 +13,7 @@ cd knowledge-base
yarn install --dev
```

これで環境は構築できました。
これで環境は構築できました！
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: Disallow to use "！". (ja-technical-writing/no-exclamation-question-mark)

Sakuten-Automation
Sakuten-Automation reviewed Mar 16, 2019
View reviewed changes
docs/misc/wiki-usage/how-to-add-post.md Outdated
@@ -35,6 +35,8 @@ git push origin feature/your-post

PRがマージされると、デプロイされたWikiで追加された項目を見ることができるようになります。お疲れ様でした。

TODO: WOWOWO
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: Found TODO: 'TODO: WOWOWO' (no-todo)

@coord-e coord-e mentioned this pull request Mar 17, 2019
Open
@Cj-bc
Copy link
Member

Cj-bc commented Mar 17, 2019

yarn run textfix or yarn run textlint-fix or yarn run fix ... 🤔
@coord-e
これは解決した？
Lintだけでなく修正もしてくれるならfixでいいと思う。（textfix/textlint-fixは長い。区別する必要がないなら直感的なfixで良いかと）

@coord-e
Copy link
Contributor Author

coord-e commented Mar 17, 2019 •
edited
Loading

yarn run textfix or yarn run textlint-fix or yarn run fix ... 🤔
@coord-e
これは解決した？
Lintだけでなく修正もしてくれるならfixでいいと思う。（textfix/textlint-fixは長い。区別する必要がないなら直感的なfixで良いかと）

textlint:fixにした(前例があったので)
fixでもいいが、これから「サンプルコードを修正」みたいなことでfixを使いたくなる可能性がなくもないので

@anharu2394
Copy link
Member

yarn textlint:fixの動作確認をしました。
オッケーだと思います。

anharu2394
anharu2394 approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@anharu2394 anharu2394 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

textlintありがとうございます。
自分の文章が直されて嬉しいです。
コード、設定いいと思います。

@anharu2394 anharu2394 merged commit bd56268 into develop Mar 22, 2019
@anharu2394 anharu2394 deleted the feature/textlint-ci branch March 22, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sakuten-Automation Sakuten-Automation Sakuten-Automation left review comments

@anharu2394 anharu2394 anharu2394 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coord-e @Cj-bc @anharu2394 @Sakuten-Automation