Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerのcontextを一つ親ディレクトリに持ち上げる #52

Merged
merged 7 commits into from
Mar 29, 2019

Conversation

shino16
Copy link
Member

@shino16 shino16 commented Mar 26, 2019

変更内容

docker-compose -f unit_test/docker-compose.yml build
  • backendのunit testでのwarningsを取り除くためにこのコマンドの実行が必要

修正前の挙動:

Building frontend
ERROR: Forbidden path outside the build context: ../unit_test/Dockerfile.frontend ()

修正後の挙動:

正常にビルド開始

影響範囲

  • あったら教えてください

@shino16 shino16 closed this Mar 26, 2019
@shino16 shino16 force-pushed the feature/shift-up-docker-context branch from e1080c0 to 22a2273 Compare March 26, 2019 14:02
@shino16
Copy link
Member Author

shino16 commented Mar 26, 2019

Dockerfileの方もfrontendとかではなく${FRONTEND_DIR}とすべきだったのですが、残念ながらWindowsでこれやるとfrontend\となぜかバックスラッシュに置換されてしまいうまくいきませんでした

@shino16
Copy link
Member Author

shino16 commented Mar 29, 2019

これないとWindowsでユニットテストかけられないみたいです

@Sakuten-Automation Sakuten-Automation had a problem deploying to sakuten-api-testflight-pr-52 March 29, 2019 17:15 Failure
@shino16 shino16 merged commit 02ea463 into develop Mar 29, 2019
@shino16 shino16 deleted the feature/shift-up-docker-context branch March 29, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants