Skip to content

fix(accordion): prevent scroll on Space key press #7441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

fix(accordion): prevent scroll on Space key press #7441

merged 2 commits into from
Jul 23, 2025

Conversation

nuria1110
Copy link
Contributor

fix #7429

Proposed behaviour

Page does not scroll when using Space key to expand Accordion.

Current behaviour

Page scrolls when using Space key to expand Accordion

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Fixes issue where page would scoll when Space key was used to open the Accordion.

fix #7429
@nuria1110 nuria1110 marked this pull request as ready for review July 17, 2025 12:03
@nuria1110 nuria1110 requested review from a team as code owners July 17, 2025 12:03
@nuria1110 nuria1110 merged commit 95075f1 into master Jul 23, 2025
28 checks passed
@nuria1110 nuria1110 deleted the FE-7411 branch July 23, 2025 15:36
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 155.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Accessibility issue: Accordion openning with spacebar scrolls page down
5 participants