Skip to content

fix(text-editor, note): ensure links have correct styles #7304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

fix(text-editor, note): ensure links have correct styles #7304

merged 3 commits into from
Apr 23, 2025

Conversation

nuria1110
Copy link
Contributor

Proposed behaviour

Links within TextEditor and Note match Carbon's Link component styles:

image
image

Current behaviour

Links within TextEditor and Note have default styling:

image
image

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@nuria1110 nuria1110 self-assigned this Apr 15, 2025
@Parsium Parsium self-requested a review April 15, 2025 13:08
Parsium
Parsium approved these changes Apr 15, 2025
View reviewed changes
src/components/note/note.style.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice job cleaning up the legacy styles 👏🏼

@tomdavies73 tomdavies73 self-requested a review April 16, 2025 09:10
@tomdavies73 tomdavies73 marked this pull request as ready for review April 16, 2025 09:19
@tomdavies73 tomdavies73 requested review from a team as code owners April 16, 2025 09:19
@tomdavies73 tomdavies73 merged commit 1162676 into master Apr 23, 2025
28 checks passed
@tomdavies73 tomdavies73 deleted the FE-7189 branch April 23, 2025 13:29
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 153.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parsium Parsium Parsium approved these changes

@stephenogorman stephenogorman stephenogorman approved these changes

@tomdavies73 tomdavies73 tomdavies73 approved these changes

Assignees

@nuria1110 nuria1110

Labels
Passed QA Passed Review Passed UX QA released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nuria1110 @carbonci @Parsium @stephenogorman @tomdavies73 @harpalsingh