Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix registry upload and add host property #75

Merged
merged 1 commit into from
Apr 9, 2024
Merged

🐛 fix registry upload and add host property #75

merged 1 commit into from
Apr 9, 2024

Conversation

dzove855
Copy link
Member

@dzove855 dzove855 commented Apr 9, 2024

No description provided.

@dzove855 dzove855 requested review from fanshan and lvenier April 9, 2024 12:37
@dzove855 dzove855 self-assigned this Apr 9, 2024
lvenier
lvenier approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@lvenier lvenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will do the trick but bulk patch it not recommended to handle errors :)

@dzove855 dzove855 merged commit 9da85fa into main Apr 9, 2024
1 check passed
@dzove855 dzove855 deleted the fix_registry_host_property branch April 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvenier lvenier lvenier approved these changes

@fanshan fanshan Awaiting requested review from fanshan

Assignees

@dzove855 dzove855

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzove855 @lvenier