Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Force pull image #114

Merged
merged 5 commits into from
Jul 17, 2024
Merged

✨ Force pull image #114

merged 5 commits into from
Jul 17, 2024

Conversation

linkdd
Copy link
Collaborator

@linkdd linkdd commented Jul 16, 2024

Decision Record

An image should be pulled if the request received on the endpoint /api/engine/images matches the following criteria:

  • the size of the image is less than, or equal to 0 (meaning, the image has not been pulled yet)
  • the field force is set to true (meaning, we want to repull the image)

Changes

  • 💡 Give names to nodes to clarify the workflow
  • ✨ Update condition to determine if we should pull an image or not
  • 🔖 v0.30.0

@linkdd linkdd requested review from lvenier and dzove855 July 16, 2024 12:28
@linkdd linkdd self-assigned this Jul 16, 2024
Copy link
Contributor

@lvenier lvenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull image tested.
new feature to pull existing image not tested.

@linkdd linkdd merged commit 3d4dcc2 into main Jul 17, 2024
1 check passed
@linkdd linkdd deleted the force-pull branch July 17, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants