-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix neg_threshold #1191
base: master
Are you sure you want to change the base?
Fix neg_threshold #1191
Conversation
the default was threshold: float = 0.5
- neg_threshold: float = threshold - 0.15
+ neg_threshold: float = max(threshold - 0.15, 0)
min_speech_duration_ms: int = 0
max_speech_duration_s: float = float("inf")
min_silence_duration_ms: int = 2000
speech_pad_ms: int = 400 this would remove the need for other changes as it will not be edit: and since there is no issue if it is a negative value, then even the solution above is not needed, it will be merely cosmetic |
Yeah, I didn't looked if there is an issue, just that it's that way in the original silero [it's not zero] -> repo |
5ec4046
to
85d91e9
Compare
I can't set the threshold itself in v 1.1.0 (and can't read it from vad.VadOptions). |
Look there: #1181 |
Fix neg_threshold.
Now it should work properly, before its default was hardcoded to 0.35