Skip to content

fix(ChartFooter): Link the logotype to our website #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

fix(ChartFooter): Link the logotype to our website #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f48e7a0
Build out feature
awesomephant Nov 10, 2025
bf7d683
Merge branch 'main' into fix-244
awesomephant Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/src/ChartFooter/ChartFooter.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
</script>

<Story name="One-up" asChild>
<DesignTokens>
<DesignTokens theme="light">
<ChartFooter layout="one-up">
Daten: <a href="#1">Zensus 2022</a>
(Durchschnittsmieten und Einwohnerzahlen),
Expand All @@ -24,7 +24,7 @@
</Story>

<Story name="One-up Centered" asChild>
<DesignTokens>
<DesignTokens theme="light">
<ChartFooter layout="one-up" align="center">
Daten: <a href="#1">Zensus 2022</a>
(Durchschnittsmieten und Einwohnerzahlen),
Expand All @@ -44,7 +44,7 @@
});
}}
>
<DesignTokens>
<DesignTokens theme="light">
<ChartFooter layout="one-up" align="center" showLogo={false}>
Daten: <a href="#1">Zensus 2022</a>
(Durchschnittsmieten und Einwohnerzahlen),
Expand Down
16 changes: 15 additions & 1 deletion components/src/ChartFooter/ChartFooter.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@
</Note>
{/if}
{#if showLogo}
<Logotype />
<a href="https://www.swr.de/home/swr-data-lab-team-100.html" class="logo-link">
SWR Data Lab
<Logotype />
</a>
{/if}
</footer>

Expand All @@ -33,6 +36,17 @@
width: 100%;
}
}

.logo-link {
font-size: 0;
&:hover,
&:focus-visible {
:global(path) {
fill: var(--color-logoFillHover);
}
}
}

.one-up {
display: flex;
flex-flow: column;
Expand Down
2 changes: 2 additions & 0 deletions components/src/DesignTokens/DesignTokens.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
--color-textSecondary: var(--textSecondary-light);
--color-textSecondaryHover: var(--textSecondaryHover-light);
--color-logoFill: var(--logoFill-light);
--color-logoFillHover: var(--logoFillHover-light);
--color-pageFill: var(--pageFill-light);
--color-surfaceFill: var(--surfaceFill-light);
--color-surfaceHover: var(--surfaceHover-light);
Expand All @@ -66,6 +67,7 @@

&[data-theme='dark'] {
--color-logoFill: var(--logoFill-dark);
--color-logoFillHover: var(--logoFillHover-dark);
--color-pageFill: var(--pageFill-dark);
--color-surfaceFill: var(--surfaceFill-dark);
--color-surfaceBorder: var(--surfaceBorder-dark);
Expand Down
6 changes: 5 additions & 1 deletion components/src/DesignTokens/Tokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,13 @@ const semantics: ColourMap = {
dark: '#b4b4b4'
},
logoFill: {
light: shades.gray.light3,
light: shades.gray.light1,
dark: shades.gray.base
},
logoFillHover: {
light: shades.gray.base,
dark: shades.gray.light1
},
surfaceFill: {
dark: '#222325',
light: '#ffffff'
Expand Down