[IDLE-248] github actions workflow 수정 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0112leesy
approved these changes
Aug 31, 2023
| @@ -254,9 +254,9 @@ void searchBookListByCategory() throws IOException { | |||
| // when | |||
| BookListByCategorySearchResultResponse response = aladinBookSearchApiService.searchBookListByCategory(request); | |||
|
|
|||
| // then | |||
| // then정 | |||
There was a problem hiding this comment.
r3: 정신없이 코드 고치시다가 한 글자 더 추가된 것 같네용 🫢 다음에 레포 이사 가신 다음에 수정하셔도 될 것 같습니다!
- config-server에서 config-client로 수정
- fargate 동작시, eureka 서버에 private ip가 아닌 메타데이터의 ip가 등록된다. - shell script를 통해 런타임 시점에서 메타데이터 ip에 등록된 private ip를 가져오도록 함. - with @0112leesy
minnseong
force-pushed
the
cicd/IDLE-248
branch
from
c787620
to
434cae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑💻 작업 사항
모든 작업을 @0112leesy 와 하였습니다!!
Book-Service, User-Service ECR-ECS work flow 분리
api-gateway 서버 의존성 추가 및 수정
Book-Service, User-Service Dockerfile 수정 및 shell script 추가
Book-Service, User-Service Request 로깅 추가
🔗 링크
🐰 시급한 정도
🐢 천천히 : 급하지 않습니다.
📖 참고 사항