Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.sh: use ninja #303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

build.sh: use ninja #303

wants to merge 2 commits into from

Conversation

gerion0
Copy link
Contributor

@gerion0 gerion0 commented Aug 25, 2020

This has the main advantage that ninja uses all cores per default resulting in a faster compilation on machines with more or less than 4 cores.

See #302 for more discussion.

@mbarbar
Copy link
Contributor

mbarbar commented Feb 25, 2021

One concern with ninja for C++ projects is the high memory usage. For example, I have 8 GB of memory and 4 cores/8 threads on one of my machines and last I tried ninja, it using all available CPU caused the machine to halt from OOM. For make, I limit myself to j4 on that machine. Not sure if there is a way to limit meory given to ninja.

@gerion0
Copy link
Contributor Author

gerion0 commented Feb 26, 2021

-j4 reduces the memory only as a side effect. The option actually limits the number of parallel jobs to 4 at maximum. Ninja has the exact same option, so ninja -j4 should behave similar to make -j4. Maybe, it is a good idea to propagate this argument to the user? So build.sh e.g. uses all 32 cores by default (much faster given that enough RAM is available) but can be limited with build.sh -jX to use less cores.

@mbarbar
Copy link
Contributor

mbarbar commented Feb 26, 2021

I wasn't aware controlling jobs was possible in ninja. I guess I never checked? Thanks haha. I like the idea of giving build.sh an optional -j argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants