WIP: remember load/store sizes during graphs building #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello..
Following up on our discussion in #232, here is a work in progress PR and I appreciate any feedbacks.
Especially in following:
addComplexConsForExt
, I am trying to get the total size of each field. Apparently, only utilizingSymbolTableInfo::getTypeSizeInBytes
return the size for the element itself but not if it was an array. So I wrote a lambda that calculates the size. but I feel there is an easier way? Please let me know.addLoadEdge
&addStoreEdge
.. but I did left a comment there to point them out and I made the added argument optional for backward compatibility. Any advice here is appreciated.Any feedback is welcomed :)
Thanks.