Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: remember load/store sizes during graphs building #258

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

WIP: remember load/store sizes during graphs building #258

wants to merge 7 commits into from

Conversation

man9ourah
Copy link

Hello..

Following up on our discussion in #232, here is a work in progress PR and I appreciate any feedbacks.

Especially in following:

  • In addComplexConsForExt, I am trying to get the total size of each field. Apparently, only utilizing SymbolTableInfo::getTypeSizeInBytes return the size for the element itself but not if it was an array. So I wrote a lambda that calculates the size. but I feel there is an easier way? Please let me know.
  • Due to my limited knowledge in SVF, I did not know how to get the size for quite a few of the invocations of addLoadEdge & addStoreEdge .. but I did left a comment there to point them out and I made the added argument optional for backward compatibility. Any advice here is appreciated.
  • Finally, do we need to propagate this further to VFG? or PAG is the place for it?

Any feedback is welcomed :)

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant