Move ExtAPI annotations to the application #1543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1543 +/- ##
==========================================
- Coverage 62.64% 62.62% -0.02%
==========================================
Files 243 244 +1
Lines 25706 25744 +38
Branches 4525 4526 +1
==========================================
+ Hits 16103 16123 +20
- Misses 9603 9621 +18
|
yuleisui
reviewed
Sep 6, 2024
svf-llvm/lib/LLVMModule.cpp
Outdated
| OrderedSet<string> declNames, defNames, intersectNames; | ||
| typedef Map<string, const Function*> NameToFunDefMapTy; | ||
| typedef Map<string, Set<const Function*>> NameToFunDeclsMapTy; | ||
| FunDeclToDefMapTy extFuncs2ClonedFuncs; |
yuleisui
reviewed
Sep 6, 2024
svf-llvm/lib/LLVMModule.cpp
Outdated
| @@ -1038,6 +977,39 @@ void LLVMModuleSet::buildFunToFunMap() | |||
| } | |||
| } | |||
|
|
|||
| auto cloneAndReplaceFunction = [&](const Function* functionToClone, Function* srcFunction, Module* parentModule, bool cloneBody) -> Function* | |||
There was a problem hiding this comment.
srcFunction => appFunToReplace
functionToClone => extFunToClone
yuleisui
reviewed
Sep 6, 2024
svf-llvm/lib/LLVMModule.cpp
Outdated
| // Without annotations, this function is normal function with useful function body | ||
| if (it == ExtFun2Annotations.end()) | ||
| { | ||
| Function* clonedFunction = cloneAndReplaceFunction(const_cast<Function*>(extfun), const_cast<Function*>(fdecl), nullptr, true); |
There was a problem hiding this comment.
extfun => extFun
fdecl => appFun
yuleisui
reviewed
Sep 6, 2024
svf-llvm/lib/LLVMModule.cpp
Outdated
| } | ||
| return clonedFunction; | ||
| }; | ||
|
|
||
| /// App Func decl -> SVF extern Func def | ||
| for (const Function* fdecl : funDecls) |
yuleisui
reviewed
Sep 6, 2024
svf-llvm/lib/LLVMModule.cpp
Outdated
| { | ||
| Function* clonedFunction = cloneAndReplaceFunction(const_cast<Function*>(owfunc), const_cast<Function*>(appfunc), nullptr, true); | ||
| extFuncs2ClonedFuncs[owfunc] = clonedFunction; | ||
| ExtFuncsVec.push_back(owfunc); |
shuangxiangkan
force-pushed
the
master
branch
from
46dce8d
to
f11838c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.