Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check LTSS product to verify #1225

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Check LTSS product to verify #1225

merged 4 commits into from
Nov 6, 2024

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Sep 4, 2024

Description

After a non free extension has been activated successfully on a PAYG system, RMT calls ZypperAuth verify_instance method without any other information, the SCC verification of the activation would fail as there is no product info to check against

Adding the product id present in the request params, that way RMT can fetch the product class and verify properly

This Fixes bsc#1230154

  • Related Issue / Ticket / Trello card: 1230154

How to test

  • clean up registration of a PAYG system
  • re-register the instance
  • register a LTSS extension on that registered PAYG instance (i.e. 15.4) -> should work
  • remove LTSS extension
  • register a LTSS extension on that registered PAYG instance -> should work

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

After a non free extension has been activated successfully
on a PAYG system, RMT calls ZypperAuth verify_instance method
without any other information, the SCC verification of the activation
would fail as there is no product info to check against

Adding the product id present in the request params,
that way RMT can fetch the product class and verify properly

This Fixes bsc#1230154
@jesusbv jesusbv added Public Cloud do not merge do not merge until this label is removed labels Sep 4, 2024
@jesusbv jesusbv self-assigned this Sep 4, 2024
@jesusbv jesusbv marked this pull request as ready for review September 23, 2024 10:38
@jesusbv jesusbv removed the do not merge do not merge until this label is removed label Sep 23, 2024
@jesusbv jesusbv merged commit 2fadb57 into master Nov 6, 2024
3 checks passed
@jesusbv jesusbv deleted the ltss-verification branch November 6, 2024 15:41
@jesusbv jesusbv mentioned this pull request Nov 11, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants