Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Packages.xz support #1184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Packages.xz support #1184

wants to merge 3 commits into from

Conversation

j0hax
Copy link

@j0hax j0hax commented Jul 3, 2024

Description

Hello there! I noticed that the main Debian Bookworm repository works well with RMT, but the Debian-Security repository only copies dists/ without the pool/ directory which contains the packages. Upon inspection of the RMT code I realized that only Packages.gz files are parsed, which are not contained in the Debian-Security repo.

How to test

Mirror http://security.debian.org/debian-security/dists/bookworm-security/main/binary-all/ or any repository which uses the .xz variant over Packages.gz

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

@j0hax j0hax force-pushed the debian-xz branch 2 times, most recently from b9de44d to 2a78f59 Compare July 4, 2024 10:11
@j0hax
Copy link
Author

j0hax commented Jul 8, 2024

Also, the Debian Repository Format states:

Servers should offer only xz compressed files, except for the special cases listed above. Some historical clients may only understand gzip compression, if these need to be supported, gzip-compressed files may be offered as well.

I believe parsing both formats should be fine for now, but maybe it would be an idea to (at some point in the far future) phase out reading Packages.gz?

@j0hax
Copy link
Author

j0hax commented Jul 8, 2024

Friendly ping to @ngetahun

@digitaltom
Copy link
Member

Could you please fix the lint issue (rubocop), and make sure the unit tests are green (rspec). Thank you :-)

@ngetahun
Copy link
Contributor

@j0hax Please extend existing unit tests. Do you have repos in mind still using xz?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants