Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how fence_kdump works #415

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Clarify how fence_kdump works #415

merged 3 commits into from
Sep 24, 2024

Conversation

tahliar
Copy link
Collaborator

@tahliar tahliar commented Sep 13, 2024

PR creator: Description

Hopefully this makes the fence_kdump example clearer.

PR creator: Are there any relevant issues/feature requests?

  • bsc#1228931
  • jsc#DOCTEAM-537

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLE-HA 15
    • 15 next (current main, no backport necessary)
    • 15 SP6
    • 15 SP5
    • 15 SP4
    • 15 SP3
    • 15 SP2
  • SLE-HA 12
    • 12 SP5

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

bsc#1228931
jsc#DOCTEAM-537
@tahliar
Copy link
Collaborator Author

tahliar commented Sep 13, 2024

Updated Sept 20

image
image

xml/ha_fencing.xml Outdated Show resolved Hide resolved
xml/ha_fencing.xml Outdated Show resolved Hide resolved
xml/ha_fencing.xml Outdated Show resolved Hide resolved
xml/ha_fencing.xml Outdated Show resolved Hide resolved
@tahliar
Copy link
Collaborator Author

tahliar commented Sep 20, 2024

Thanks @zzhou1! I applied your fixes and made a couple of little edits. Let me know if you're happy with it :)

Copy link
Contributor

@zzhou1 zzhou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, Tahlia!

Copy link
Contributor

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tahliar tahliar merged commit 641157f into main Sep 24, 2024
4 checks passed
@tahliar tahliar deleted the DOCTEAM-537-clarify-kdump branch September 24, 2024 02:51
tahliar added a commit that referenced this pull request Sep 24, 2024
* Clarify how fence_kdump works

bsc#1228931
jsc#DOCTEAM-537

* Apply suggestions from code review

Co-authored-by: Roger Zhou <[email protected]>

* Small edits

---------

Co-authored-by: Roger Zhou <[email protected]>
tahliar added a commit that referenced this pull request Sep 24, 2024
* Clarify how fence_kdump works

bsc#1228931
jsc#DOCTEAM-537

* Apply suggestions from code review

Co-authored-by: Roger Zhou <[email protected]>

* Small edits

---------

Co-authored-by: Roger Zhou <[email protected]>
tahliar added a commit that referenced this pull request Sep 24, 2024
* Clarify how fence_kdump works

bsc#1228931
jsc#DOCTEAM-537

* Apply suggestions from code review

Co-authored-by: Roger Zhou <[email protected]>

* Small edits

---------

Co-authored-by: Roger Zhou <[email protected]>
tahliar added a commit that referenced this pull request Sep 24, 2024
* Clarify how fence_kdump works

bsc#1228931
jsc#DOCTEAM-537

* Apply suggestions from code review

Co-authored-by: Roger Zhou <[email protected]>

* Small edits

---------

Co-authored-by: Roger Zhou <[email protected]>
tahliar added a commit that referenced this pull request Sep 24, 2024
* Clarify how fence_kdump works

bsc#1228931
jsc#DOCTEAM-537

* Apply suggestions from code review

Co-authored-by: Roger Zhou <[email protected]>

* Small edits

---------

Co-authored-by: Roger Zhou <[email protected]>
tahliar added a commit that referenced this pull request Sep 24, 2024
* Clarify how fence_kdump works

bsc#1228931
jsc#DOCTEAM-537

* Apply suggestions from code review

Co-authored-by: Roger Zhou <[email protected]>

* Small edits

---------

Co-authored-by: Roger Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants