Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement confirmation dialog for deleting items #110

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Implement confirmation dialog for deleting items #110

wants to merge 6 commits into from

Conversation

elliotwutingfeng
Copy link
Contributor

@elliotwutingfeng elliotwutingfeng commented Oct 24, 2022 •
edited
Loading

Addresses #109

Changes

  • Added 2 entry deletion confirmation dialog toggles, one for favorite entries, and the other for non-favorite entries. Both toggles are enabled by default.

Help wanted

  • Fixing the language locales
  • Phrasing of the confirmation dialog messages; should we put the entry contents in the dialog message? Currently it looks like this, could be prettier:
    image

@SUPERCILEX
Copy link
Owner

Can you extract the readme changes into another PR? I'd like to accept that right away.

@elliotwutingfeng
Copy link
Contributor Author

Can you extract the readme changes into another PR? I'd like to accept that right away.

Done. There is still the locale which has not been updated yet.

@elliotwutingfeng elliotwutingfeng marked this pull request as draft October 26, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elliotwutingfeng @SUPERCILEX