-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain Fetcher Circuit Breaker & Circuit Breaker Manager #1756
Open
jordevo
wants to merge
13
commits into
master
Choose a base branch
from
feat-domain-fetcher-circuit-breaker
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordevo
requested review from
sui-bot,
kikoruiz,
andresz1 and
carlosvillu
as code owners
May 3, 2024 11:12
jordevo
changed the title
Feat domain fetcher circuit breaker
Domain fetcher circuit breaker
May 3, 2024
jordevo
commented
May 16, 2024
Comment on lines
+10
to
+13
failureCount = 0 | ||
failureThreshold = 5 // number of failures to determine when to open the circuit | ||
resetAfter = 50000 | ||
timeout = 5000 // declare request failure if the function takes more than 5 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these default settings can be overridden by passing an options
object to the CircuitBreakerManager
constructor
jordevo
changed the title
Domain fetcher circuit breaker
Domain Fetcher Circuit Breaker & Circuit Breaker Manager
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Example