Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue 1418: [@s-ui/pde] use structured args in useFeature #1472

Closed
wants to merge 3 commits into from
Closed

Fix for Issue 1418: [@s-ui/pde] use structured args in useFeature #1472

wants to merge 3 commits into from

Commits on Oct 5, 2022

  1. fix: [@s-ui/pde] update useFeature hook to accept structured args ins… 

    …tead of raw args

- In order to maintain coherency between the useExperiment and useFeature hooks, refactor the useFeature hook to accept structured args.
- Update unit tests
    @theonly1me
    theonly1me committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    751e6fc View commit details
    Browse the repository at this point in the history

  2. docs: [@s-ui/pde] update README.md to account for refactoring of the … 

    …useFeature hook
    @theonly1me
    theonly1me committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    f726a64 View commit details
    Browse the repository at this point in the history

  3. docs: [@s-ui/pde] correct spelling mistake in CONTRIBUTING.md 

    Correct the spelling from 'versionning' to 'versioning'
    @theonly1me
    theonly1me committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    b5262af View commit details
    Browse the repository at this point in the history