Skip to content

Commit

Permalink
Merge pull request #641 from SUI-Components/chore-linter-new-line-length
Browse files Browse the repository at this point in the history
Apply new linter line length rule
  • Loading branch information
jordevo committed Dec 4, 2023
2 parents 507c855 + 38e762c commit 22103ea
Show file tree
Hide file tree
Showing 242 changed files with 711 additions and 2,789 deletions.
137 changes: 26 additions & 111 deletions components/abtesting/hooks/jest-tests/experiment-core.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import Enzyme, {mount} from 'enzyme'

import Adapter from '@wojtekmaj/enzyme-adapter-react-17'

import AbTestOptimizelyXExperiment, {
getExperimentContext
} from '../../optimizelyXExperiment/src'
import AbTestOptimizelyXExperiment, {getExperimentContext} from '../../optimizelyXExperiment/src'
import {useExperiment as useExperimentRaw, useExperimentCore} from '../src'
import OptimizelyX from '../src/useExperimentCore/optimizely-x'

Expand All @@ -18,38 +16,27 @@ jest.useFakeTimers()
// configure dependencies
const useExperiment = params =>
useExperimentRaw(
typeof params === 'string'
? {getExperimentContext, name: params}
: {getExperimentContext, ...params}
typeof params === 'string' ? {getExperimentContext, name: params} : {getExperimentContext, ...params}
)
const OptimizelyXExperiment = props => (
<AbTestOptimizelyXExperiment {...props} deps={{useExperimentCore}} />
)
const OptimizelyXExperiment = props => <AbTestOptimizelyXExperiment {...props} deps={{useExperimentCore}} />

describe('Experiment', () => {
let activationHandler

beforeEach(() => {
const noop = () => {}
activationHandler = {single: noop}
jest
.spyOn(OptimizelyX, 'addActivationListener')
.mockImplementation((experimentId, handler) => {
activationHandler.single = handler
activationHandler[experimentId] = handler
})
jest.spyOn(OptimizelyX, 'addActivationListener').mockImplementation((experimentId, handler) => {
activationHandler.single = handler
activationHandler[experimentId] = handler
})
})

afterEach(() => {
OptimizelyX.addActivationListener.mockRestore()
})

const assertActivation = (
Component,
expectedFromDefault,
variationId,
expectedFromVariation
) => {
const assertActivation = (Component, expectedFromDefault, variationId, expectedFromVariation) => {
let mounted
act(() => {
mounted = mount(<Component />)
Expand Down Expand Up @@ -88,11 +75,7 @@ describe('Experiment', () => {
() => {
const experimentData = useExperiment({
experimentId: 40000,
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
return (
<OptimizelyXExperiment feed={experimentData}>
Expand All @@ -119,11 +102,7 @@ describe('Experiment', () => {
const experimentData = useExperiment({
name: 'myexperiment',
experimentId: 40000,
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
return (
<OptimizelyXExperiment feed={experimentData}>
Expand Down Expand Up @@ -164,20 +143,12 @@ describe('Experiment', () => {
const catsExperimentData = useExperiment({
name: 'cats',
experimentId: 40000,
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const dogsExperimentData = useExperiment({
name: 'dogs',
experimentId: 50000,
variations: [
{id: 900000, isDefault: true},
{id: 900001},
{id: 900002}
]
variations: [{id: 900000, isDefault: true}, {id: 900001}, {id: 900002}]
})
return (
<OptimizelyXExperiment feed={catsExperimentData}>
Expand Down Expand Up @@ -222,20 +193,12 @@ describe('Experiment', () => {
() => {
const catsExperimentData = useExperiment({
experimentId: 40000,
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const dogsExperimentData = useExperiment({
name: 'dogs',
experimentId: 50000,
variations: [
{id: 900000, isDefault: true},
{id: 900001},
{id: 900002}
]
variations: [{id: 900000, isDefault: true}, {id: 900001}, {id: 900002}]
})
return (
<OptimizelyXExperiment feed={catsExperimentData}>
Expand All @@ -261,11 +224,7 @@ describe('Experiment', () => {
() => {
const experimentData = useExperiment({
experimentId: 40000,
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const {isWrapped} = experimentData
return isWrapped.toString()
Expand All @@ -281,11 +240,7 @@ describe('Experiment', () => {
() => {
const experimentData = useExperiment({
experimentId: 40000,
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const {isActive} = experimentData
return isActive.toString()
Expand All @@ -301,11 +256,7 @@ describe('Experiment', () => {
() => {
const experimentData = useExperiment({
experimentId: 40000,
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const {isDefault} = experimentData
return isDefault.toString()
Expand All @@ -321,11 +272,7 @@ describe('Experiment', () => {
() => {
const experimentData = useExperiment({
experimentId: 40000,
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const {isVariation} = experimentData
return isVariation.toString()
Expand All @@ -341,11 +288,7 @@ describe('Experiment', () => {
() => {
const experimentData = useExperiment({
experimentId: 40000,
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const {experimentId, variationId} = experimentData
return `${experimentId}/${variationId}`
Expand All @@ -361,11 +304,7 @@ describe('Experiment', () => {
() => {
const experimentData = useExperiment({
experimentId: 40000,
variations: [
{id: 700000},
{id: 700001},
{id: 700002, isDefault: true}
]
variations: [{id: 700000}, {id: 700001}, {id: 700002, isDefault: true}]
})
const {variationName} = experimentData
return variationName
Expand All @@ -381,11 +320,7 @@ describe('Experiment', () => {
() => {
const experimentData = useExperiment({
experimentId: 40000,
variations: [
{id: 700000},
{id: 700001},
{id: 700002, isDefault: true}
]
variations: [{id: 700000}, {id: 700001}, {id: 700002, isDefault: true}]
})
const {isVariationA, isVariationB, isVariationC} = experimentData
return `${isVariationA}:${isVariationB}:${isVariationC}`
Expand All @@ -402,11 +337,7 @@ describe('Experiment', () => {
const experimentData = useExperiment({
experimentId: 40000,
forceVariation: 700001, // B
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const {variationName} = experimentData
return variationName
Expand All @@ -423,11 +354,7 @@ describe('Experiment', () => {
const experimentData = useExperiment({
experimentId: 40000,
forceVariation: 'B',
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const {variationName} = experimentData
return variationName
Expand All @@ -444,11 +371,7 @@ describe('Experiment', () => {
const experimentData = useExperiment({
experimentId: 40000,
forceActivation: 700001, // B
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const {variationName} = experimentData
return variationName
Expand All @@ -465,11 +388,7 @@ describe('Experiment', () => {
const experimentData = useExperiment({
experimentId: 40000,
forceActivation: 'B',
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const {variationName} = experimentData
return variationName
Expand All @@ -489,11 +408,7 @@ describe('Experiment', () => {
onActivation: experimentData => {
dataFromOnActivation = experimentData
},
variations: [
{id: 700000, isDefault: true},
{id: 700001},
{id: 700002}
]
variations: [{id: 700000, isDefault: true}, {id: 700001}, {id: 700002}]
})
const {variationName} = experimentData
return variationName
Expand Down
4 changes: 1 addition & 3 deletions components/abtesting/hooks/jest-tests/optimizely-x.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ describe('OptimizelyXExperiments', () => {
get: jest.fn().mockReturnValue({
getExperimentStates: () => fakeExperiments
}),
push: jest
.fn()
.mockImplementation(listener => (sdkHandler = listener.handler))
push: jest.fn().mockImplementation(listener => (sdkHandler = listener.handler))
}
})

Expand Down
4 changes: 1 addition & 3 deletions components/abtesting/hooks/src/index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
export default function ReactHooks() {
/* eslint-disable-next-line no-console */
console.warn(
"[@s-ui/react-abtesting-hooks] can't be used as a standalone package.\nYou must import a specific hook."
)
console.warn("[@s-ui/react-abtesting-hooks] can't be used as a standalone package.\nYou must import a specific hook.")
return null
}

Expand Down
4 changes: 1 addition & 3 deletions components/abtesting/hooks/src/useExperiment/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ export default (params = {}) => {
const contextGetter = getExperimentContext || getExperimentContextFromPackage
const experimentName = typeof params === 'string' ? params : params.name
const ExperimentContext = contextGetter(experimentName)
const experimentData =
useContext(ExperimentContext) ||
NON_WRAPPED_BY_CONTEXT_PROVIDER_FALLBACK_OBJECT
const experimentData = useContext(ExperimentContext) || NON_WRAPPED_BY_CONTEXT_PROVIDER_FALLBACK_OBJECT
return experimentData
}
Loading

0 comments on commit 22103ea

Please sign in to comment.