Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rust version to 1.84 #299

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Upgrade Rust version to 1.84 #299

merged 7 commits into from
Jan 17, 2025

Conversation

DanNixon
Copy link
Member

Summary of changes

Moves to Rust 1.84.
Something higher than 1.80 was required to move to the maintained fork of hdf5.

This also addresses a few new warnings generated.

Instruction for review/testing

  • basic test with simulated data
  • review modified code

@DanNixon DanNixon requested a review from Modularius January 17, 2025 10:19
@DanNixon DanNixon force-pushed the upgrade-rust-version branch from cf310db to 00c6467 Compare January 17, 2025 11:17
@DanNixon DanNixon mentioned this pull request Jan 17, 2025
Copy link
Contributor

@Modularius Modularius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the main Cargo.toml, line 51 should be updated to
taos = { version = "0.10.27", default-features = false, features = ["ws"] }
as default_features is deprecated.

trace-to-events/src/pulse_detection/datatype/tracepoint.rs Outdated Show resolved Hide resolved
@DanNixon DanNixon force-pushed the upgrade-rust-version branch from 00c6467 to 136fed7 Compare January 17, 2025 13:55
@DanNixon DanNixon requested a review from Modularius January 17, 2025 13:57
@DanNixon DanNixon force-pushed the upgrade-rust-version branch from 136fed7 to a91dae4 Compare January 17, 2025 13:58
@DanNixon DanNixon merged commit aebd1df into main Jan 17, 2025
9 checks passed
@DanNixon DanNixon deleted the upgrade-rust-version branch January 17, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants