Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SYCL build and other typos #458

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Fix SYCL build and other typos #458

merged 2 commits into from
Sep 1, 2023

Conversation

G-071
Copy link
Member

@G-071 G-071 commented Sep 1, 2023

A stray " / " managed to make it into the code, causing the SYCL builds to fail (we really need a SYCL Jenkins pipeline to catch errors like these, but I leave that for a future PR). Alongside removing the " / ", I also fixed a few other typos in error messages and added some information regarding the SYCL future type printed during the octotiger initialization.

Lastly, I began replacing cerr with cout where appropriate (partially addressing #454 ).

@G-071 G-071 requested a review from diehlpk September 1, 2023 05:08
Copy link
Member

@diehlpk diehlpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diehlpk diehlpk merged commit dc4125a into master Sep 1, 2023
@diehlpk diehlpk deleted the fix_typos branch September 1, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants