Move get_stack_ptr to source #6594
Open
+46
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers to build/use hpx
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
hkaiser
reviewed
Dec 19, 2024
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <hpx/config.hpp> | |||
| #include <hpx/config/compiler_specific.hpp> | |||
| #include <hpx/config/defines.hpp> | |||
There was a problem hiding this comment.
If you include <hpx/config.hpp>, then the other two #includes are not needed anymore (those are pulled in by it).
hkaiser
reviewed
Dec 19, 2024
| @@ -28,28 +29,6 @@ | |||
| #include <limits> | |||
|
|
|||
| namespace hpx::threads::coroutines::detail { | |||
There was a problem hiding this comment.
Since the function is defined only for #if !defined(HPX_WINDOWS), shouldn't it be declared only in that case as well?
There was a problem hiding this comment.
I think what you are describing already happens since
extends to the bottom of the document
Performance test reportHPX PerformanceComparison
Info
Comparison
Info
Comparison
Info
Explanation of Symbols
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_stack_ptr()is moved to a source file so it still works when there is a mismatch in the features of the compiler building HPX and the compiler building the HPX headers along with the application that uses them.