Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated headers from HPX #27

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Conversation

msimberg
Copy link
Collaborator

@msimberg msimberg commented Dec 11, 2024

  • Don't use deprecated hpx/local/... headers
  • Rename test entry points to test_main due to HPX in earlier versions declaring multiple overloads of hpx_main
  • Only use -Wno-error=#warnings on specific configurations that require it

@msimberg msimberg requested review from hkaiser and G-071 December 11, 2024 09:45
@msimberg msimberg force-pushed the deprecated-headers branch 4 times, most recently from 601412c to 27e460d Compare December 11, 2024 10:43
@msimberg msimberg marked this pull request as ready for review December 11, 2024 11:07
…headers are no longer used

Leave the flag for some CI configurations, where Kokkos still includes
deprecated HPX headers.
HPX prior to 1.10 forward declares multiple hpx_main overloads when
including hpx/hpx_init.hpp. This means that one would have to
disambiguate the overload to pass to hpx::init. Instead of
disambiguating, rename the entry point to avoid conflicts.
@msimberg msimberg merged commit 9b9beb0 into master Dec 13, 2024
6 checks passed
@msimberg msimberg deleted the deprecated-headers branch December 13, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant