Update summit build #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-071
reviewed
Feb 8, 2022
| #DIR_INSTALL=${INSTALL_ROOT}/octotiger | ||
|
|
||
| if [[ ! -d ${DIR_SRC} ]]; then | ||
| git clone https://github.com/STEllAR-GROUP/octotiger.git ${DIR_SRC} | ||
| pushd ${DIR_SRC} | ||
| git checkout master | ||
| git submodule update --init --recursive |
There was a problem hiding this comment.
Why stop checking out the testdata? This would require us to adapt all Jenkins CI pipelines to add this as an additional step (in addition to do this manually for all of our other builds).
| DIR_SRC=${SOURCE_ROOT}/octotiger | ||
| DIR_BUILD=${INSTALL_ROOT}/octotiger/build | ||
| DIR_SRC=${SOURCE_ROOT}/octotiger-kokkos | ||
| DIR_BUILD=${INSTALL_ROOT}/octotiger/build-kokkos |
There was a problem hiding this comment.
I don't particularly like this change (breaks some of my scripts and my own muscle memory :-) )
Is there a specific reason for it?
| -DHPXKokkos_DIR=$INSTALL_ROOT/hpx-kokkos/install/${LIB_DIR_NAME}/cmake/HPXKokkos | ||
| -DHPXKokkos_DIR=$INSTALL_ROOT/hpx-kokkos/install/${LIB_DIR_NAME}/cmake/HPXKokkos \ | ||
| -DCMAKE_CXX_COMPILER="${OCT_CMAKE_CXX_COMPILER}" \ | ||
| -DOCTOTIGER_WITH_GRIDDIM=16 |
| -DOCTOTIGER_WITH_TESTS=ON \ | ||
| -DOCTOTIGER_WITH_Vc=ON \ | ||
| -DOCTOTIGER_WITH_TESTS=OFF \ | ||
| -DOCTOTIGER_WITH_Vc=OFF \ |
There was a problem hiding this comment.
I would keep these on ON as we don't gain anything by turning it OFF yet (as some old methods still pull in Vc)
| git checkout ${HPX_KOKKOS_VERSION} | ||
| cd .. | ||
| ) |
There was a problem hiding this comment.
Why should we remove this but not the opening parenthesis?
| @@ -47,7 +47,6 @@ if [[ ! -d ${DIR_SRC} ]]; then | |||
| cd hpx | |||
| git checkout ${HPX_VERSION} | |||
| cd .. | |||
| ) | |||
There was a problem hiding this comment.
Why should we remove this but not the opening parenthesis?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.