Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online instrumentation mode #117

Merged
merged 6 commits into from
Aug 23, 2021

Conversation

andre15silva
Copy link
Contributor

I'm working on this PR, which features a new mode for getting the covered test results through online instrumentation, instead of through offline instrumentation as it is the case of all modes right now.

The advantages are:

The PR's main work is finished. Tomorrow I'll finish adding tests and testing the remaining integration with flacoco and other tools.

Early feedback is appreciated though, specifically if you want to merge some test-runner modes.

@andre15silva
Copy link
Contributor Author

coveralls is failing because it doesn't find the source files of the jacoco agent.

The coveralls-maven-plugin does not have the option to ignore these errors (trautonen/coveralls-maven-plugin#113).

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ee045f4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #117   +/-   ##
=========================================
  Coverage          ?   41.08%           
  Complexity        ?      321           
=========================================
  Files             ?       68           
  Lines             ?     2529           
  Branches          ?      189           
=========================================
  Hits              ?     1039           
  Misses            ?     1425           
  Partials          ?       65           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee045f4...1516ef5. Read the comment docs.

@andre15silva
Copy link
Contributor Author

@danglotb I have cherry-picked the commits that replace the coverage platform to #118.

After that is merged, I'll rebase here and this will be ready too.

@andre15silva andre15silva marked this pull request as ready for review August 23, 2021 07:01
@andre15silva
Copy link
Contributor Author

Thank you @danglotb !

This one is ready now too.

@andre15silva
Copy link
Contributor Author

@danglotb do you have any timeline of when you will be able to review this PR?

This PR is blocking ASSERT-KTH/flacoco#86, SpoonLabs/astor#323 and SpoonLabs/nopol#220 and I'd like to finish it them by the end of this week (when I finish my internship) 😅

@danglotb danglotb merged commit b937cb2 into STAMP-project:master Aug 23, 2021
@andre15silva
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants