Closed
Conversation
thalman
approved these changes
Apr 3, 2025
Contributor
thalman
left a comment
thalman
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for the effort
arrowd
commented
Apr 7, 2025
alexey-tikhonov
approved these changes
Apr 7, 2025
Member
|
@thalman, please take the look at the updated version. |
Member
|
@arrowd, could you please rebase? |
According to POSIX standard [1] it is sys/socket.h header that defines AF_UNSPEC and SOCK_STREAM. [1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html
While there, fix typo in the definition of cli_creds_get_gid()
thalman
approved these changes
Apr 9, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.