Tests: Test trasformation SSSD does not crash in nss responder after … #7831
+111
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborah-sudo
force-pushed
the
new_net
branch
9 times, most recently
from
e798b58 to
05ae5f2
Compare
Comment on lines
353
to
351
| if isinstance(provider, (AD)): | ||
| bad_ldap_uri = "typo.dc.%s" % hostname | ||
| client.sssd.dom("test").update(ad_server=bad_ldap_uri) |
There was a problem hiding this comment.
Suggested change
| if isinstance(provider, (AD)): | |
| bad_ldap_uri = "typo.dc.%s" % hostname | |
| client.sssd.dom("test").update(ad_server=bad_ldap_uri) | |
| if isinstance(provider, (AD)) or isinstance(provider, (Samba)): | |
| bad_ldap_uri = "typo.dc.%s" % hostname | |
| client.sssd.dom("test").update(ad_server=bad_ldap_uri) |
Comment on lines
361
to
363
| if isinstance(provider, (Samba)): | ||
| bad_ldap_uri = "typo.dc.%s" % hostname | ||
| client.sssd.dom("test").update(ad_server=bad_ldap_uri) |
There was a problem hiding this comment.
Suggested change
| if isinstance(provider, (Samba)): | |
| bad_ldap_uri = "typo.dc.%s" % hostname | |
| client.sssd.dom("test").update(ad_server=bad_ldap_uri) |
| bad_ldap_uri = "typo.dc.%s" % hostname | ||
| client.sssd.dom("test").update(ad_server=bad_ldap_uri) | ||
|
|
||
| if isinstance(provider, (IPA)): |
There was a problem hiding this comment.
Suggested change
| if isinstance(provider, (IPA)): | |
| elif isinstance(provider, (IPA)): |
| bad_ldap_uri = "typo.dc.%s" % hostname | ||
| client.sssd.dom("test").update(ad_server=bad_ldap_uri) | ||
|
|
||
| if isinstance(provider, (LDAP)): |
There was a problem hiding this comment.
Suggested change
| if isinstance(provider, (LDAP)): | |
| elif isinstance(provider, (LDAP)): |
| client.host.conn.run(pgrep) | ||
|
|
||
| pid_nss2 = client.host.conn.run(pid_nss).stdout | ||
| assert pid_nss1 == pid_nss2 |
There was a problem hiding this comment.
Please add meaningfull assert message.
|
|
||
|
|
||
| @pytest.mark.importance("low") | ||
| @pytest.mark.ticket(bz=1406437) |
There was a problem hiding this comment.
I think that we can drop the allocation error check and if everything else is covered elsewhere drop it altogether.
| @pytest.mark.topology(KnownTopologyGroup.AnyProvider) | ||
| def test_netgroup__nss_responder(client: Client, provider: GenericProvider): | ||
| """ | ||
| :title: SSSD does not crash in nss responder after netgroup timeout when backend is offline |
There was a problem hiding this comment.
Suggested change
| :title: SSSD does not crash in nss responder after netgroup timeout when backend is offline | |
| :title: SSSD nss responder handles correctly netgroup timeout when backend is offline |
| 6. Verify that the SSSD processes (sssd, sssd_be, sssd_nss, sssd_pam) are still running and that the | ||
| sssd_nss process ID has not changed, indicating that SSSD has not crashed or restarted unexpectedly | ||
| :expectedresults: | ||
| 1. SSSD configured with incorrect server backend |
There was a problem hiding this comment.
Suggested change
| 1. SSSD configured with incorrect server backend | |
| 1. SSSD configured with incorrect server URI |
| 1. Depending on the type of provider (AD, IPA, Samba, or LDAP), the script updates the SSSD configuration | ||
| with an incorrect server URI (e.g., typo.dc.hostname) | ||
| 2. SSSD is restarted again to apply the new configuration | ||
| 3. Checks the status of the SSSD domain to ensure it is offline due to the misconfigured server |
There was a problem hiding this comment.
Suggested change
| 3. Checks the status of the SSSD domain to ensure it is offline due to the misconfigured server | |
| 3. Check the status of the SSSD domain. |
| :expectedresults: | ||
| 1. SSSD configured with incorrect server backend | ||
| 2. SSSD restarted | ||
| 3. SSSD Offline |
There was a problem hiding this comment.
Suggested change
| 3. SSSD Offline | |
| 3. SSSD domain is offline |
| 2. SSSD restarted | ||
| 3. SSSD Offline | ||
| 4. Pid of sssd_nss captured | ||
| 5. Netgroup info cant be retrieve |
There was a problem hiding this comment.
Suggested change
| 5. Netgroup info cant be retrieve | |
| 5. Netgroup info can't be retrieved. |
| 3. SSSD Offline | ||
| 4. Pid of sssd_nss captured | ||
| 5. Netgroup info cant be retrieve | ||
| 6. SSSD not crashed |
There was a problem hiding this comment.
Suggested change
| 6. SSSD not crashed | |
| 6. SSSD nss responder has the same pid as before. |
Comment on lines
348
to
350
| result = client.tools.getent.netgroup(netgroup.name) | ||
| assert result is not None | ||
| assert result.members[0].user == "user-1" |
There was a problem hiding this comment.
Suggested change
| result = client.tools.getent.netgroup(netgroup.name) | |
| assert result is not None | |
| assert result.members[0].user == "user-1" |
Not a test step.
| netgroup = provider.netgroup("ng-1").add().add_member(user=user) | ||
|
|
||
| result = client.tools.getent.netgroup(netgroup.name) | ||
| assert result is not None |
There was a problem hiding this comment.
Suggested change
| assert result is not None | |
| assert result is not None, "Could not get netgroup ng-1" |
…netgroup timeout when backend is offline SSSD does not crash in nss responder after netgroup timeout when backend is offline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…netgroup timeout when backend is offline
SSSD does not crash in nss responder after netgroup timeout when backend is offline