Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Test trasformation #7831

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

aborah-sudo
Copy link
Contributor

@aborah-sudo aborah-sudo commented Feb 7, 2025

Test transformation net group with generic provider

@aborah-sudo aborah-sudo force-pushed the new_net branch 2 times, most recently from 85bd068 to c8ffaa7 Compare March 3, 2025 14:20
@aborah-sudo aborah-sudo requested a review from ikerexxe March 3, 2025 14:21
@aborah-sudo aborah-sudo force-pushed the new_net branch 4 times, most recently from b3af7ea to 67af1f0 Compare March 4, 2025 10:28
@aborah-sudo aborah-sudo requested a review from danlavu March 5, 2025 05:28
@aborah-sudo aborah-sudo changed the title Tests: Test trasformation netgroup Tests: Test trasformation Mar 7, 2025
@aborah-sudo aborah-sudo requested review from danlavu and removed request for danlavu March 16, 2025 15:04
@danlavu
Copy link

danlavu commented Mar 17, 2025

  1. What are we testing, netgroup or entry_cache_nowait_percentage?
  2. If entry_cache_nowait_percentage, should we test users and regular groups as well?

If netgroup, and we only create netgroups and assert netgroups, this should go in test_netgroup.py, as it is right now, this is where it should go. If we can extend the test to users, groups, it should go in test_cache.py.

@aborah-sudo
Copy link
Contributor Author

  1. What are we testing, netgroup or entry_cache_nowait_percentage?

    1. If entry_cache_nowait_percentage, should we test users and regular groups as well?

If netgroup, and we only create netgroups and assert netgroups, this should go in test_netgroup.py, as it is right now, this is where it should go. If we can extend the test to users, groups, it should go in test_cache.py.

I am moving this test to test_netgroup.py again, before this test was placed there

…netgroup timeout when backend is offline

SSSD does not crash in nss responder after netgroup timeout when backend is offline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants